From 67f8293d919b23569f50d89a6fe8c2ac01998fc5 Mon Sep 17 00:00:00 2001 From: SuperMuel <69467005+SuperMuel@users.noreply.github.com> Date: Thu, 14 May 2026 12:46:57 -0700 Subject: [PATCH 1/3] fix(skills): misleading DCE advice in setup-harness `benchmark.pedantic` is not a dead-code-elimination tool; it controls the measurement loop. CPython doesn't perform the kind of DCE that `black_box` guards against in compiled languages, so pure-Python benchmarks don't need an equivalent. List the actual primitives for the languages that do (C++: DoNotOptimize, JMH: Blackhole.consume). --- skills/codspeed-setup-harness/SKILL.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/skills/codspeed-setup-harness/SKILL.md b/skills/codspeed-setup-harness/SKILL.md index 1fe35771..68fa819b 100644 --- a/skills/codspeed-setup-harness/SKILL.md +++ b/skills/codspeed-setup-harness/SKILL.md @@ -287,7 +287,7 @@ Good benchmarks are representative, isolated, and stable. Here are guidelines: - **Avoid benchmarking setup**: Use the framework's setup/teardown mechanisms to exclude initialization from measurements. -- **Prevent dead code elimination**: Use `black_box()` (Rust), `benchmark.pedantic()` (Python), or equivalent to ensure the compiler/runtime doesn't optimize away the work you're measuring. +- **Prevent dead code elimination**: Use `black_box()` (Rust), `benchmark::DoNotOptimize` (C++), or `Blackhole.consume` (JMH) so the compiler doesn't optimize away unused results. - **Cover the critical path**: Benchmark the functions that matter most to your users — the ones called frequently or on the hot path. From 74f78009c7cd95273079a699be3e3105c6d60e42 Mon Sep 17 00:00:00 2001 From: SuperMuel <69467005+SuperMuel@users.noreply.github.com> Date: Thu, 14 May 2026 13:00:03 -0700 Subject: [PATCH 2/3] fix(skills): drop trailing whitespace Caught by the trailing-whitespace pre-commit hook on PR #350. --- skills/codspeed-setup-harness/SKILL.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/skills/codspeed-setup-harness/SKILL.md b/skills/codspeed-setup-harness/SKILL.md index 68fa819b..d8f7fe1b 100644 --- a/skills/codspeed-setup-harness/SKILL.md +++ b/skills/codspeed-setup-harness/SKILL.md @@ -287,7 +287,7 @@ Good benchmarks are representative, isolated, and stable. Here are guidelines: - **Avoid benchmarking setup**: Use the framework's setup/teardown mechanisms to exclude initialization from measurements. -- **Prevent dead code elimination**: Use `black_box()` (Rust), `benchmark::DoNotOptimize` (C++), or `Blackhole.consume` (JMH) so the compiler doesn't optimize away unused results. +- **Prevent dead code elimination**: Use `black_box()` (Rust), `benchmark::DoNotOptimize` (C++), or `Blackhole.consume` (JMH) so the compiler doesn't optimize away unused results. - **Cover the critical path**: Benchmark the functions that matter most to your users — the ones called frequently or on the hot path. From d395403355a80b2b2b04686fb3559f0f92e5fa2b Mon Sep 17 00:00:00 2001 From: SuperMuel <69467005+SuperMuel@users.noreply.github.com> Date: Fri, 15 May 2026 16:44:11 -0700 Subject: [PATCH 3/3] fix(ci): restore toolchain auto-install on macOS lint `rustup show` stopped auto-installing the active toolchain in rustup 1.28 (March 2025). The change in 9afaef7 happened to keep working because the macOS-15-arm64 runner image at the time still shipped an older rustup; once GitHub rolled out image 20260511.0048 with rustup >= 1.28, /Users/runner/.cargo/bin/cargo stayed as the rustup-init shim and `cargo fmt`/`cargo clippy` started failing in lint (macos-latest) with `unexpected argument 'fmt' found`. Per the rustup 1.28 release notes, the explicit replacement is `rustup toolchain install`, which is what this action used before. --- .github/actions/install-rust/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/install-rust/action.yml b/.github/actions/install-rust/action.yml index 04bee8af..37e9fd06 100644 --- a/.github/actions/install-rust/action.yml +++ b/.github/actions/install-rust/action.yml @@ -10,7 +10,7 @@ runs: steps: - name: Install rust-toolchain.toml shell: bash - run: rustup show + run: rustup toolchain install - name: Install additional rustup components if: inputs.components != '' shell: bash