Skip to content

hardening(cycle): html_escape rfilter and leaf title before HTML output #22

@somethingwithproof

Description

@somethingwithproof

Summary

cycle.php:312 echoes $leaf['title'] (from the database) and cycle.php:323 echoes $rfilter (from a request variable) into HTML without html_escape(). Either value can contain HTML/JavaScript that executes in the browser of authenticated users viewing the plugin.

Details

Field Value
File cycle.php
Lines 312, 323
Auth required Yes — authenticated Cacti user
CWE CWE-79
// Line 312 — before
echo $leaf['title'];
// after
echo html_escape($leaf['title']);

// Line 323 — before
value="<?php echo $rfilter; ?>"
// after
value="<?php echo html_escape($rfilter); ?>"

Fix applied in branch security/cycle-html-escape-output.

Acceptance criteria

  • html_escape() applied to $leaf['title'] at line 312
  • html_escape() applied to $rfilter at line 323
  • Regression tests in tests/Security/CycleParamTest.php

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions