feat: require DOI for dissertations metadata check#757
Merged
sakshamarora1 merged 1 commit intoMay 19, 2026
Merged
Conversation
TahaKhan998
force-pushed
the
fix/dissertation-doi-metadata-check
branch
from
c508439 to
c352c63
Compare
TahaKhan998
force-pushed
the
fix/dissertation-doi-metadata-check
branch
2 times, most recently
from
8d817a5 to
e26d2d1
Compare
Contributor
zubeydecivelek
left a comment
zubeydecivelek
left a comment
There was a problem hiding this comment.
Looks good!
Just a small thing: From your screenshot i dont see the error message
Normally it looks like this :)
TahaKhan998
force-pushed
the
fix/dissertation-doi-metadata-check
branch
from
e26d2d1 to
a5d0d17
Compare
Author
Good catch, thanks. The validation was firing, but the field-level message wasn’t being anchored properly because the rule was missing error_path. I’ve added that now, so the DOI error shows up in the right place, and I also updated the screenshot. |
TahaKhan998
force-pushed
the
fix/dissertation-doi-metadata-check
branch
from
a5d0d17 to
9d64306
Compare
palkerecsenyi
approved these changes
May 19, 2026
sakshamarora1
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #586
This PR adds a metadata check to require a DOI for dissertation records.
A new rule was added to scripts/metadata_checks.py so that when the resource type is publication-dissertation, the metadata check validates that pids.doi.identifier is not empty.
Recipe:
After web deployment —
metadata_checksRun the metadata-checks script to register the new metadata check that requires a DOI for dissertation records (
publication-dissertation) on the CERN Scientific community: