Migration lep#520
Open
kpsherva wants to merge 6 commits into
Open
Conversation
Comment on lines
+466
to
+472
| if subject.get("subject", "") in ["xx"]: | ||
| del subject | ||
|
|
||
| subjects(json_entry) |
Contributor
There was a problem hiding this comment.
Since we already check in the rule, you think it's needed? Or if we need should we also check select: other subjects to delete?
Contributor
Author
There was a problem hiding this comment.
yes we can move the whole clean up here. Let's move it after merging your PR, when we have all the values to drop?
| "bookchapter", | ||
| "itcerntalk", | ||
| "slides", | ||
| "antarescerntalk" "slides", |
Contributor
There was a problem hiding this comment.
"antarescerntalk",
"slides",
is this intended?
* chore(tests): fix testing cases, formatting
zubeydecivelek
force-pushed
the
migration-lep
branch
from
61f4c9f to
6e98a4b
Compare
zubeydecivelek
approved these changes
May 20, 2026
|
|
||
|
|
||
| def test_migrate_comments_dry_run(temp_dir): | ||
| def test_migrate_comments_dry_run(temp_dir, test_app, db): |
| } | ||
|
|
||
|
|
||
| # @model.over("_approvals", "^903__") |
Contributor
There was a problem hiding this comment.
Will this be needed?
I see that we also removed role from the tests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it is best to review commit by commit
PR introduces some slight performance improvements
needs: CERNDocumentServer/cds-rdm#795