Skip to content

[Suggestion] Refactor Contract class to make it usable outside of out-of-the-box protocols #18

Description

@andreujuanc

Hi,

I'm about to start experimenting with this library, but I saw that the Contract class is "blocked" from being extended properly.
My proposal would be to change the constructor https://github.com/BitGo/eth-contracts/blob/master/src/contract/index.ts#L77 to be proper, and have other alternatives to read from the file system.
Even just an overload would be sufficient.
My use case is that I might want to use that class for a built-in protocol (Compound for example) but also to use a custom one that would make no sense to integrate into this library as a PR.

Best,

JC

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions