feat(statics): onboard CECHO-1941 top-1000 unsupported tokens - #9536
Open
manojkumar138 wants to merge 1 commit into
Open
Conversation
CECHO-1941 Onboard the batch of BSC/Base/Arbitrum/Polygon/Tron tokens that fall under the top 1000 assets list, per the ticket's two source spreadsheets (only rows with Price match = True): - BSC (42 tokens): beat, velvet, genius, tag, ab, cheems, bank, wfi, uai, nila, xpin, gps, lab, bdca, glidr, cross, pm, bsb, lusd, wkc, aio, collect, ain, b2, giggle, aleo, lista, tpt, gcb, xny, tac, idol, bluai, clo, hajimi, bdx, spcxb, sndkb, bananas31, coai, nes, mgo - Base (8): awe, tibbir, kta, diem, bnkr, fai, roll, zen - Arbitrum (2): rain, mlk - Polygon (1): apepe - Tron (1): real Decimals and contract addresses were verified independently via on-chain eth_call/tronscan lookups rather than trusting the sheet: - B2 and ALEO: sheet claimed 0 decimals; on-chain is 18 and 6 respectively. - BSB, TAC, NES: the sheet's 'contracts' column address had no deployed bytecode for these three; used the address from the 'explorers' column link instead, which is the real ERC20 contract. Adds base.ts UnderlyingAsset entries, per-chain token definitions, and OFC counterparts for all 54 tokens. Entity-level gating (per the ticket's 'keep gated for all trust for now') is handled separately at the AMS/prime-microservices layer, not in BitGoJS statics. Ticket: CECHO-1941
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Onboards the batch of tokens falling under the top-1000-assets list, per the ticket's two source spreadsheets (only rows with
Price match = True):Decimals and contract addresses were verified independently on-chain (
eth_call/tronscan) rather than trusting the sheet:B2andALEO: sheet claimed 0 decimals; on-chain is 18 and 6 respectively.BSB,TAC,NES: the sheet's "contracts" column address had no deployed bytecode for these three — used the address from the "explorers" column link instead (the real deployed ERC20 contract).Adds
base.tsUnderlyingAssetentries, per-chain token definitions, and OFC counterparts for all 54 tokens.Note: The ticket asks to "keep it gated for all the trust for now" — that's an AMS/prime-microservices-layer concern (gatekeep.ts / backing-wallet config), not a BitGoJS statics change, so it's not included here. Will follow up with those changes separately.
Ticket
CECHO-1941
Test plan
tsc --noEmit,eslint, and the full statics unit-test suite (35117 passing) all pass locally