fix(ci): use Client ID (not App ID) for create-github-app-token

The create-github-app-token action deprecated app-id in favour of
client-id. These inputs accept different values: app-id takes the
numeric App ID (1819979), client-id takes the alphanumeric OAuth
Client ID (Iv23lipbCWzUuCxFerKJ).

Rename STATIC_ANALYSIS_BOT_APP_ID to STATIC_ANALYSIS_BOT_CLIENT_ID,
set value to Iv23lipbCWzUuCxFerKJ, rename app-id to client-id,
and upgrade action from v2 to v3.
Ref: BitGo/advanced-wallets#233

Ticket: AI-273
Session-Id: 4ea37ed2-bb6a-43da-848a-66a70262d221
Task-Id: 4523dbe1-5473-46a2-824f-14a84177962f

Author: ericcrosson-bitgo

.github/workflows/audit-api-spec.yaml

@@ -7,7 +7,7 @@ on:
       - rel/**
 
 env:
-  STATIC_ANALYSIS_BOT_APP_ID: 1819979
+  STATIC_ANALYSIS_BOT_CLIENT_ID: Iv23lipbCWzUuCxFerKJ
 jobs:
   generate-head-api-spec:
     name: Generate head API spec
@@ -236,7 +236,7 @@ jobs:
         id: generate-github-app-token
         uses: actions/create-github-app-token@v3
         with:
-          client-id: ${{ env.STATIC_ANALYSIS_BOT_APP_ID }}
+          client-id: ${{ env.STATIC_ANALYSIS_BOT_CLIENT_ID }}
           private-key: ${{ secrets.STATIC_ANALYSIS_BOT_PRIVATE_KEY }}
           owner: bitgo
           repositories: |