fix(statics): skip ams tokens that duplicate an existing contract address

createTokenMapUsingConfigDetails merges dynamic AMS token configs into the statics
coin map. The presence guard (isCoinPresentInCoinMap) dedupes only by name, id, and
alias, but CoinMap.fromCoins also dedupes by contract address
(family:networkType:contractAddress) and throws DuplicateContractAddressDefinitionError
on a collision.

A dynamic AMS token that shares a contract address with a statics token under a
different name -- e.g. drift between the generated botTokens snapshot and live AMS
data (eth:at on hoodi testnet) -- slipped past the name guard and threw in
fromCoins, aborting the entire token-map build for every consumer
(bitgo-retail hydration, bitgo-admin, bitgo-microservices, etc.).

Track contract-address keys while merging and skip a duplicate with a warning,
mirroring the existing malformed-token handling, so one bad token can no longer
take down the whole map.

Author: mmcshinsky-bitgo

modules/statics/src/coins.ts

@@ -8,6 +8,7 @@ import {
   bscToken,
   celoToken,
   cosmosToken,
+  ContractAddressDefinedToken,
   eosToken,
   erc20,
   hederaToken,
@@ -463,9 +464,14 @@ export function createTokenMapUsingConfigDetails(tokenConfigMap: Record<string,
     'terc1155:soneiumtoken',
   ]);
 
-  // Add all the coins from statics coin map first
+  // Add all the coins from statics coin map first, tracking the contract-address keys
+  // they occupy (family:networkType:contractAddress, matching CoinMap.addCoin).
+  const seenContractAddressKeys = new Set<string>();
   coins.forEach((coin, coinName) => {
     BaseCoins.set(coinName, coin);
+    if (coin instanceof ContractAddressDefinedToken) {
+      seenContractAddressKeys.add(`${coin.family}:${coin.network.type}:${coin.contractAddress}`);
+    }
   });
 
   // add the tokens not present in the static coin map
@@ -477,6 +483,22 @@ export function createTokenMapUsingConfigDetails(tokenConfigMap: Record<string,
       try {
         const token = createToken(tokenConfig);
         if (token) {
+          // The name/id/alias guard above can miss a dynamic AMS token that shares a
+          // contract address with a statics token (or another AMS token) under a different
+          // name -- e.g. drift between the generated botTokens snapshot and live AMS data.
+          // CoinMap.fromCoins dedupes by contract address and would throw
+          // DuplicateContractAddressDefinitionError, aborting the entire token-map build.
+          // Skip the duplicate with a warning instead, mirroring the malformed-token handling.
+          if (token instanceof ContractAddressDefinedToken) {
+            const contractAddressKey = `${token.family}:${token.network.type}:${token.contractAddress}`;
+            if (seenContractAddressKeys.has(contractAddressKey)) {
+              console.warn(
+                `Skipping token with duplicate contract address: name="${token.name}" id="${token.id}" key="${contractAddressKey}"`
+              );
+              continue;
+            }
+            seenContractAddressKeys.add(contractAddressKey);
+          }
           BaseCoins.set(token.name, token);
         }
       } catch (e) {

modules/statics/test/unit/coins.ts

@@ -1320,6 +1320,34 @@ describe('create token map using config details', () => {
     tokenMap.has('hteth:faketoken').should.eql(false);
   });
 
+  it('should skip an ams token that duplicates an existing contract address instead of throwing', () => {
+    const baseConfig = amsTokenConfigWithCustomToken['hteth:faketoken'][0];
+    // Two ams tokens with distinct names/ids but the same family + network type + contract address.
+    // The name/id/alias guard does not catch this, so without contract-address dedup the second
+    // token would throw DuplicateContractAddressDefinitionError in CoinMap.fromCoins and abort the
+    // entire token-map build (the failure observed via syncAmsCoinsToPresenter in bitgo-retail).
+    const tokenConfigWithDuplicateContract = {
+      'hteth:faketoken': [baseConfig],
+      'hteth:faketokendup': [
+        {
+          ...baseConfig,
+          id: 'f0000000-0000-4000-8000-000000000001',
+          name: 'hteth:faketokendup',
+          asset: 'hteth:faketokendup',
+        },
+      ],
+    };
+
+    let tokenMap: ReturnType<typeof createTokenMapUsingConfigDetails> | undefined;
+    (() => {
+      tokenMap = createTokenMapUsingConfigDetails(tokenConfigWithDuplicateContract);
+    }).should.not.throw();
+
+    // The first token wins; the contract-address duplicate is skipped.
+    tokenMap!.has('hteth:faketoken').should.eql(true);
+    tokenMap!.has('hteth:faketokendup').should.eql(false);
+  });
+
   it('should create a coin map using reduced token config details', () => {
     const coinMap1 = createTokenMapUsingTrimmedConfigDetails(reducedAmsTokenConfig);
     const amsToken1 = coinMap1.get('hteth:faketoken');