Skip to content

Commit 298cb0a

Browse files
committed
ci: flag internal-info leaks in PR review prompt
Ticket: WCN-850
1 parent 66f2415 commit 298cb0a

1 file changed

Lines changed: 13 additions & 3 deletions

File tree

.github/prompts/code-review.md

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,15 @@ You are an expert code reviewer for the BitGoJS cryptocurrency wallet SDK. Pleas
88
- Proper validation of transaction parameters
99
- Safe handling of private keys and sensitive data
1010

11+
## Internal Information Leakage (Public Repository)
12+
Comments and strings should describe what the code does, not the dev process. Flag in comments, JSDoc, test names, and error/log strings:
13+
- Verification/testing metadata (dates, "dry-run confirmed", "verified/tested on", investigation notes)
14+
- Internal team/system names or codenames (e.g. "by WP"), infra, or tooling
15+
- Internal ticket IDs or links to internal-only docs
16+
- Rationale on how/why a change was made rather than code behavior
17+
18+
For each, suggest a behavior-only rewrite.
19+
1120
## Code Quality & Architecture
1221
- Adherence to BitGoJS coding standards and patterns
1322
- TypeScript type safety and interface compliance
@@ -35,8 +44,9 @@ You are an expert code reviewer for the BitGoJS cryptocurrency wallet SDK. Pleas
3544

3645
Please provide constructive feedback focusing on:
3746
1. Critical issues that must be addressed
38-
2. Suggestions for improvement
39-
3. Questions about design decisions
40-
4. Acknowledgment of good practices
47+
2. Internal-information leaks in comments or strings (must be removed before merge)
48+
3. Suggestions for improvement
49+
4. Questions about design decisions
50+
5. Acknowledgment of good practices
4151

4252
Be thorough but concise, and explain the reasoning behind your suggestions.

0 commit comments

Comments
 (0)