[Bug] RegisterActEvent 事件注册无效。

[Eiskomet]

模块范围

Public API（公开 API）

严重程度

Broken feature（功能不可用）

发生了什么？

在几个版本前，我编写了一个事件将其注册在密林Act下，在经过测试可以正常运行。今天在开发另一个事件时通过指令切换事件发现我很多之前开发的事件都不见了。
测试后发现使用RegisterActEvent 注册的事件都失效了，改为[RegisterSharedEvent]后正常。

复现步骤

1.任意编写一个继承ModEventTemplate的事件
2.将其注册为[RegisterActEvent(typeof(Overgrowth))]
3.开启任意游戏，输入进入事件的指令。

期望行为

Event 'xxxxxxxxxx'not found

日志 / 堆栈

[INFO] [VanillaExtension] [Content] Registered relic: EnergyStone (id=VANILLA_EXTENSION_RELIC_ENERGY_STONE) -> SharedRelicPool
[INFO] [VanillaExtension] [Content] Registered relic: WhiteGemstone (id=VANILLA_EXTENSION_RELIC_WHITE_GEMSTONE) -> SharedRelicPool
[INFO] [VanillaExtension] [Content] Registered act event: PrisonerDilemmaEvent (id=VANILLA_EXTENSION_EVENT_PRISONER_DILEMMA_EVENT) -> Underdocks
[INFO] [VanillaExtension] [Content] Registered act event: SnakebiteEvent (id=VANILLA_EXTENSION_EVENT_SNAKEBITE_EVENT) -> Overgrowth

无error log

RitsuLib 版本

0.4.19

运行环境

windows 10 / 游戏版本V0.107.0 / RitsuLibV0.4.19

[ritsukage-local-analyzer]

Warning

此分析由 AI 自动生成，仅供开发者参考，最终判断请以人工确认为准。如有疑问建议结合本地环境进一步复现确认。

摘要

注册日志确认 RegisterActEvent 的注册调用成功执行，事件已进入 RegisteredActEvents 字典；但运行时通过游戏指令（event <id>）无法检索到这些事件，而同样场景下 RegisterSharedEvent 正常生效。核心原因是 ModelDb.AllEvents 存在惰性静态缓存 (_allEvents)，对其的每次调用仅通过 AllEventsPatch.Postfix 补充共享事件，而未对 Act 专属事件做等价补充；若缓存在动态 Patch 就绪之前已被填充，Act 事件将永久缺失。建议维护者优先确认 DynamicActContentPatcher 是否在 V0.107.0 下成功完成 patch，并评估在 AllEventsPatch.Postfix 中补充全部已注册 Act 事件的修复方案。

重点结论

项目	内容
简单介绍	使用 RegisterActEvent 注册的事件在游戏 event 指令下无法找到，改用 RegisterSharedEvent 则正常。
可能原因 1（高置信）	ModelDb.AllEvents 含静态缓存 _allEvents；AllEventsPatch.Postfix 仅为每次调用追加共享事件，而 Act 专属事件仅能在 _allEvents 首次构建时（通过 Acts.SelectMany(a => a.AllEvents) + 每个 Act 的 Harmony Postfix）加入。若游戏 V0.107.0 在 DynamicActContentPatcher.EnsurePatched() 生效前就触发了 ModelDb.AllEvents，缓存即告污染，Act 事件永久丢失，而共享事件因每次调用均被 AllEventsPatch.Postfix 补充而始终可见。
可能原因 2（中置信）	DynamicActContentPatcher.TryAddPropertyGetterPatch 在 V0.107.0 下静默失败（仅记录 Warning），导致 Overgrowth/Underdocks 等 Act 的 AllEvents getter 未被 Harmony 挂载，报告者日志中未出现此类 Warning，但日志截断，无法排除。
可能解决方案	① 在 AllEventsPatch.Postfix（或新增独立 patch）中额外追加所有已注册 Act 事件至 ModelDb.AllEvents，对齐共享事件的"每次调用均补充"语义；② 确认 DynamicActContentPatcher 初始化日志（查找 Could not queue getter Warning）。
需要补充	游戏日志完整内容（含 [Content] Dynamic act content patching initialized 行），确认 Patch 是否对所有目标 Act 成功注册。

展开详细分析、证据与验证

问题描述

期望行为

通过游戏内 event <id> 指令可以进入 RegisterActEvent 注册的自定义 Act 事件（如 SnakebiteEvent），与 RegisterSharedEvent 注册的事件行为一致。

实际行为

控制台输出 Event 'XXXX' not found，RegisterActEvent 注册的事件无法被找到；换用 [RegisterSharedEvent] 后恢复正常。

复现步骤

1. 编写继承 ModEventTemplate 的事件类
2. 标注 [RegisterActEvent(typeof(Overgrowth))]
3. 启动游戏，执行 event <事件ID> 指令
4. 输出 Event 'xxx' not found（将 [RegisterSharedEvent] 换掉则可正常找到）

环境与版本

• OS：Windows 10
• 游戏版本：V0.107.0
• RitsuLib：0.4.19

日志、附件与原文摘录

原文（注册日志，无 error）：

[INFO] Registered act event: PrisonerDilemmaEvent -> Underdocks
[INFO] Registered act event: SnakebiteEvent -> Overgrowth

要点：注册本身成功，问题在运行时检索阶段。

详细分析依据

调用链（event 指令）

EventConsoleCmd.Process（EventConsoleCmd.cs:36）：

private static IEnumerable<EventModel> Events => ModelDb.AllEvents.Concat(ModelDb.AllAncients);
EventModel eventModel = Events.FirstOrDefault(c => c.Id.Entry == eventName);

ModelDb.AllEvents（游戏 0.104.0 源码，行 125）：

public static IEnumerable<EventModel> AllEvents =>
    _allEvents ?? (_allEvents = Acts.SelectMany(a => a.AllEvents).Concat(AllSharedEvents).Distinct());

静态缓存 _allEvents 的构建时机

• 首次访问时通过 Acts.SelectMany(a => a.AllEvents) 遍历每个 Act 的 AllEvents 属性。
• RitsuLib 在 ModelDb.Init.Prefix（ActContentPatches.cs:28）调用 DynamicActContentPatcher.EnsurePatched()，为 Overgrowth 等 Act 的 AllEvents getter 挂载 Postfix（AllEventsPostfix），使其追加 RegisteredActEvents 中登记的事件。
• 若 _allEvents 在该 Prefix 执行前即被触发（如游戏 V0.107.0 初始化顺序变更），则缓存中不含 mod Act 事件。

关键不对称性

注册方式	在 ModelDb.AllEvents 中的维持方式
RegisterSharedEvent	AllEventsPatch.Postfix（ModelDbContentPatches.cs:199）对每次调用追加 AppendSharedEvents，无视缓存状态
RegisterActEvent	仅通过 _allEvents 首次构建时的动态 Patch 加入；AllEventsPatch.Postfix 不追加 Act 事件

一旦 _allEvents 缓存构建时动态 Patch 未就绪，Act 事件从 ModelDb.AllEvents 永久缺失，无恢复机制。

GenerateRooms 路径（ActModel.cs:227）：

List<EventModel> list = AllEvents.Concat(ModelDb.AllSharedEvents).ToList();

此处调用的是 this.AllEvents（Act 实例的属性，已通过动态 Patch 挂载），与 ModelDb.AllEvents 无关，故此路径原则上可正常包含 mod Act 事件。但 event 指令直接使用 ModelDb.AllEvents，不走此路径。

DynamicActContentPatcher 失败场景

TryAddPropertyGetterPatch（DynamicActContentPatcher.cs:103–128）对 patch 失败仅输出 Warning 级别日志：

[Content] Could not queue getter 'Overgrowth.AllEvents' for dynamic patching: ...

报告者提供的日志未包含此条目，但日志不完整，不能排除。

详细验证建议

• 在完整启动日志中搜索 Could not queue getter 和 Dynamic act content patching initialized for，确认 patch 目标 Act 数量及是否出现失败。
• 搜索 [AutoRegister] Processed assembly，确认 mod 程序集的 AutoRegistrationPhase.ContentSecondary 阶段操作数与成功数。
• 在游戏 V0.107.0 下检查 ModelDb.AllEvents 的访问时机（是否在 ModelDb.Init.Prefix 之前被触发）。
• 临时将 RegisterActEvent 改为 RegisterSharedEvent，确认症状消失（报告者已完成）。
• 尝试在 AllEventsPatch.Postfix 中追加所有已注册 Act 事件（RegisteredActEvents.Values.SelectMany(...)），观察问题是否消失。

风险与未决

• 游戏 V0.107.0 与代码库中参考源（V0.104.0）之间可能存在 ModelDb.AllEvents 实现差异，需获取新版反编译源码确认。
• 若修复方向为在 AllEventsPatch.Postfix 追加所有 Act 事件，需注意 act.GetType() 作用域（MergeScopedCatalog 按 Act 类型分组），应以聚合形式（RegisteredActEvents.Values.SelectMany）统一追加。
• 报告者使用 event 指令测试，并未明确说明自然走图时 Act 事件是否也不出现，建议补充此信息以确认 GenerateRooms 路径是否同样受影响。

---

English translation

Summary

The registration log confirms that RegisterActEvent calls complete successfully and events enter the RegisteredActEvents dictionary. However, at runtime the game's event <id> console command cannot find these events, while RegisterSharedEvent works normally in the same scenario. The root cause is a fundamental asymmetry in how ModelDb.AllEvents is supplemented: AllEventsPatch.Postfix re-appends shared events on every call, but provides no equivalent safety net for act-scoped events. If the static _allEvents cache is populated before the DynamicActContentPatcher Harmony patches are in place, act events are permanently absent from ModelDb.AllEvents with no recovery path. The recommended action is to confirm whether DynamicActContentPatcher succeeds in game V0.107.0 and evaluate supplementing all registered act events inside AllEventsPatch.Postfix to match the shared-event guarantee.

Key Takeaways

Item	Content
What's broken	Events registered with RegisterActEvent cannot be found via the in-game event <id> console command; RegisterSharedEvent works as expected.
Likely cause 1 (high confidence)	ModelDb.AllEvents has a static lazy cache (_allEvents). AllEventsPatch.Postfix appends shared events on every access, but act-scoped events can only enter the cache during its first construction (via Acts.SelectMany(a => a.AllEvents) + individual act Harmony postfixes). If game V0.107.0 accesses ModelDb.AllEvents before DynamicActContentPatcher.EnsurePatched() runs, the cache is stale and act events are permanently lost — while shared events are always recovered by AllEventsPatch.Postfix.
Likely cause 2 (medium confidence)	DynamicActContentPatcher.TryAddPropertyGetterPatch fails silently (only logs a Warning) in V0.107.0, meaning the AllEvents getters of Overgrowth/Underdocks are never Harmony-patched. The reporter's log does not show such warnings, but the log is truncated.
Recommended fixes	① Supplement all registered act events in AllEventsPatch.Postfix (or a new dedicated patch) so that ModelDb.AllEvents always includes act events regardless of cache state, mirroring the shared-event guarantee. ② Check startup logs for Could not queue getter warnings to rule out silent patch failure.
Information needed	Full startup log including the [Content] Dynamic act content patching initialized for N act type(s) line, to confirm whether all target acts were successfully patched.

Expand detailed analysis, evidence, and verification

Problem Description

Expected Behavior

The event <id> console command can find and enter events registered with RegisterActEvent (e.g., SnakebiteEvent), consistent with how RegisterSharedEvent events behave.

Actual Behavior

The console outputs Event 'XXXX' not found. Switching to [RegisterSharedEvent] resolves the issue.

Reproduction Steps

1. Write an event class inheriting ModEventTemplate
2. Annotate with [RegisterActEvent(typeof(Overgrowth))]
3. Start a run and issue event <event_id> in the console
4. Observe Event 'xxx' not found (replaced with [RegisterSharedEvent], it works)

Environment and Version

• OS: Windows 10
• Game version: V0.107.0
• RitsuLib: 0.4.19

Logs, Attachments, and Excerpts

From the reporter's log (no errors):

[INFO] Registered act event: PrisonerDilemmaEvent -> Underdocks
[INFO] Registered act event: SnakebiteEvent -> Overgrowth

Point: Registration succeeds; the failure is in runtime event discovery.

Detailed Analysis

Call chain for the event console command

EventConsoleCmd.Process (EventConsoleCmd.cs:36):

private static IEnumerable<EventModel> Events => ModelDb.AllEvents.Concat(ModelDb.AllAncients);
EventModel eventModel = Events.FirstOrDefault(c => c.Id.Entry == eventName);

ModelDb.AllEvents (game source 0.104.0, line 125):

public static IEnumerable<EventModel> AllEvents =>
    _allEvents ?? (_allEvents = Acts.SelectMany(a => a.AllEvents).Concat(AllSharedEvents).Distinct());

When _allEvents is built

• On first access, iterates Acts.SelectMany(a => a.AllEvents) for each act's AllEvents property.
• RitsuLib calls DynamicActContentPatcher.EnsurePatched() in ModelDb.Init.Prefix (ActContentPatches.cs:28), attaching a Postfix to each act's AllEvents getter that merges RegisteredActEvents entries.
• If _allEvents is triggered before this Prefix runs (e.g., due to a changed initialization order in game V0.107.0), the cache is built without mod act events.

The critical asymmetry

Registration method	How it stays in ModelDb.AllEvents
RegisterSharedEvent	AllEventsPatch.Postfix (ModelDbContentPatches.cs:199) calls AppendSharedEvents on every access, regardless of cache state
RegisterActEvent	Only enters via the _allEvents first-build path through dynamic Harmony patching; AllEventsPatch.Postfix does not append act events

If the _allEvents cache is built before dynamic patches are active, act events are permanently absent with no recovery mechanism.

GenerateRooms path (ActModel.cs:227):

List<EventModel> list = AllEvents.Concat(ModelDb.AllSharedEvents).ToList();

This uses this.AllEvents (the act instance property, which IS patched by DynamicActContentPatcher), not ModelDb.AllEvents. This path should include mod act events even when the static cache is stale. The console command, however, does not use this path.

Silent failure scenario in DynamicActContentPatcher

TryAddPropertyGetterPatch (DynamicActContentPatcher.cs:103–128) only logs a Warning on patch failure:

[Content] Could not queue getter 'Overgrowth.AllEvents' for dynamic patching: ...

The reporter's log does not show this line, but the log appears truncated, so this cannot be ruled out.

Detailed Verification Checklist

• Search the full startup log for Could not queue getter and Dynamic act content patching initialized for to confirm whether patching succeeded for all target act types and how many.
• Search for [AutoRegister] Processed assembly to verify the mod assembly's ContentSecondary-phase operation count and success count.
• In game V0.107.0, determine whether ModelDb.AllEvents is accessed before ModelDb.Init.Prefix runs (e.g., via a changed init sequence or static field access in Godot's loading path).
• Temporarily change RegisterActEvent to RegisterSharedEvent to confirm the symptom disappears (reporter has already done this).
• Prototype fix: supplement AllEventsPatch.Postfix with RegisteredActEvents.Values.SelectMany(...) and verify act events appear in the console command.

Risks and Open Questions

• The reference game source (V0.104.0) may differ from V0.107.0's ModelDb.AllEvents implementation; decompiled V0.107.0 source should be obtained to confirm.
• A fix in AllEventsPatch.Postfix would need to aggregate all act events across all registered act types (RegisteredActEvents.Values.SelectMany), rather than keying on a specific act type (as MergeScopedCatalog does), since the postfix is on a static getter with no act instance context.
• The reporter tested primarily via the event console command. It is unclear whether act events also fail to appear during normal map traversal (the GenerateRooms path). Clarifying this would help isolate whether DynamicActContentPatcher is broken (both paths fail) or only the ModelDb.AllEvents static cache is stale (only the console command path fails).

---

工具侧记录

• BAKAOLC/STS2-RitsuLib#55 · 退出码 0 · 进程 854.17s
• claude-sonnet-4-6 · API 852188ms · 49 轮 · ↓40 ↑42963 · 缓存读3435715 写151316 · $2.5832
• MCP available: management tools exposed to Claude.

[Eiskomet]

[INFO] [com.ritsukage.sts2-RitsuLib] [Content] Dynamic act content patching initialized for 5 act type(s).

[BAKAOLC]

/r set wip
你可以等待会这个提交的 dev-build 测试一下是否能正确访问

[BAKAOLC]

https://github.com/BAKAOLC/STS2-RitsuLib/releases/tag/dev-build

[Eiskomet]

好了