From 4c70b25588002cb242e86579d931b217c29023b4 Mon Sep 17 00:00:00 2001 From: Kashif Khan Date: Fri, 31 Jul 2026 12:49:27 -0500 Subject: [PATCH 1/9] fix import ordering things --- .../samples/example_truststore_injection.py | 3 +++ .../azure-core/samples/test_example_async.py | 5 ++-- .../async_tests/test_authentication_async.py | 9 ++++---- .../async_tests/test_base_polling_async.py | 10 ++++---- .../async_tests/test_basic_transport_async.py | 7 +++--- .../test_content_length_checking_async.py | 3 ++- .../test_http_logging_policy_async.py | 6 +++-- .../tests/async_tests/test_paging_async.py | 4 ++-- .../tests/async_tests/test_pipeline_async.py | 11 ++++----- .../tests/async_tests/test_request_asyncio.py | 5 ++-- .../tests/async_tests/test_request_trio.py | 6 ++--- .../test_rest_asyncio_transport.py | 10 ++++---- .../test_rest_context_manager_async.py | 5 ++-- .../async_tests/test_rest_headers_async.py | 6 +++-- .../test_rest_http_request_async.py | 6 +++-- .../test_rest_http_response_async.py | 6 +++-- .../test_rest_response_backcompat_async.py | 4 +++- .../test_rest_stream_responses_async.py | 3 ++- .../async_tests/test_rest_trio_transport.py | 7 +++--- .../async_tests/test_retry_policy_async.py | 14 ++++++----- .../test_stream_generator_async.py | 8 ++++--- .../tests/async_tests/test_streaming_async.py | 4 +++- .../async_tests/test_testserver_async.py | 3 ++- .../test_tracing_decorator_async.py | 8 +++---- .../async_tests/test_tracing_live_async.py | 5 ++-- .../async_tests/test_tracing_policy_async.py | 6 ++--- .../async_tests/test_universal_http_async.py | 11 ++++----- sdk/core/azure-core/tests/rest_client.py | 3 ++- .../azure-core/tests/test_authentication.py | 10 ++++---- .../azure-core/tests/test_base_polling.py | 4 ++-- .../azure-core/tests/test_basic_transport.py | 15 ++++++------ .../tests/test_content_length_checking.py | 3 ++- .../tests/test_custom_hook_policy.py | 6 +++-- sdk/core/azure-core/tests/test_error_map.py | 3 ++- sdk/core/azure-core/tests/test_exceptions.py | 7 +++--- .../tests/test_http_logging_policy.py | 6 +++-- .../tests/test_messaging_cloud_event.py | 3 ++- sdk/core/azure-core/tests/test_paging.py | 4 ++-- sdk/core/azure-core/tests/test_pipeline.py | 5 ++-- .../tests/test_request_id_policy.py | 7 +++--- .../tests/test_requests_universal.py | 4 +++- .../tests/test_rest_http_request.py | 7 +++--- .../tests/test_rest_http_response.py | 6 +++-- .../tests/test_rest_request_backcompat.py | 4 +++- .../azure-core/tests/test_retry_policy.py | 23 +++++++++++-------- .../azure-core/tests/test_serialization.py | 19 +++++++-------- sdk/core/azure-core/tests/test_settings.py | 3 ++- .../azure-core/tests/test_stream_generator.py | 19 +++++++-------- sdk/core/azure-core/tests/test_streaming.py | 3 ++- sdk/core/azure-core/tests/test_testserver.py | 5 ++-- sdk/core/azure-core/tests/test_tracer_otel.py | 10 ++++---- .../tests/test_tracing_decorator.py | 8 +++---- .../azure-core/tests/test_tracing_live.py | 5 ++-- .../azure-core/tests/test_tracing_policy.py | 12 +++++----- .../tests/test_universal_pipeline.py | 18 +++++++-------- .../tests/test_user_agent_policy.py | 7 +++--- .../coretestserver/coretestserver/__init__.py | 3 ++- .../coretestserver/test_routes/helpers.py | 5 ++-- sdk/core/azure-core/tests/tracing_common.py | 3 ++- sdk/core/azure-core/tests/utils.py | 17 +++++++------- 60 files changed, 241 insertions(+), 191 deletions(-) diff --git a/sdk/core/azure-core/samples/example_truststore_injection.py b/sdk/core/azure-core/samples/example_truststore_injection.py index 83389a2f55ce..d83a1cac5fca 100644 --- a/sdk/core/azure-core/samples/example_truststore_injection.py +++ b/sdk/core/azure-core/samples/example_truststore_injection.py @@ -26,6 +26,9 @@ # Inject truststore BEFORE importing Azure SDK libraries truststore.inject_into_ssl() +# Azure SDK imports must follow truststore injection so the OS certificate +# store is used for TLS; the out-of-order position is intentional here. +# pylint: disable=wrong-import-position # Synchronous imports from azure.identity import DefaultAzureCredential from azure.storage.blob import BlobServiceClient diff --git a/sdk/core/azure-core/samples/test_example_async.py b/sdk/core/azure-core/samples/test_example_async.py index a94b1331f6bf..853e988d893f 100644 --- a/sdk/core/azure-core/samples/test_example_async.py +++ b/sdk/core/azure-core/samples/test_example_async.py @@ -24,14 +24,15 @@ # # -------------------------------------------------------------------------- from typing import Iterable, MutableSequence, Union + import pytest +import trio + from azure.core.pipeline import AsyncPipeline from azure.core import AsyncPipelineClient from azure.core.pipeline.policies import AsyncHTTPPolicy, SansIOHTTPPolicy, UserAgentPolicy, AsyncRedirectPolicy from azure.core.rest import HttpRequest, AsyncHttpResponse -import trio - @pytest.mark.asyncio async def test_example_trio(): diff --git a/sdk/core/azure-core/tests/async_tests/test_authentication_async.py b/sdk/core/azure-core/tests/async_tests/test_authentication_async.py index 0be2027fe1fa..437fc0f7a7f1 100644 --- a/sdk/core/azure-core/tests/async_tests/test_authentication_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_authentication_async.py @@ -8,7 +8,12 @@ import sys import time from unittest.mock import Mock, patch, AsyncMock, create_autospec + from requests import Response +import pytest +import trio + +from utils import HTTP_REQUESTS from azure.core.credentials import AccessToken, AccessTokenInfo from azure.core.credentials_async import AsyncTokenCredential, AsyncSupportsTokenInfo @@ -23,10 +28,6 @@ ) from azure.core.pipeline.policies._authentication import MAX_REFRESH_JITTER_SECONDS from azure.core.pipeline.transport import AsyncHttpTransport, HttpRequest -import pytest -import trio - -from utils import HTTP_REQUESTS @pytest.mark.asyncio diff --git a/sdk/core/azure-core/tests/async_tests/test_base_polling_async.py b/sdk/core/azure-core/tests/async_tests/test_base_polling_async.py index 56e5e44a4e24..3e4582059f82 100644 --- a/sdk/core/azure-core/tests/async_tests/test_base_polling_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_base_polling_async.py @@ -26,27 +26,25 @@ import base64 import json import re -from utils import HTTP_REQUESTS -from azure.core.pipeline._tools import is_rest import types from unittest import mock import pytest - from requests import Request, Response +from utils import HTTP_REQUESTS +from utils import ASYNCIO_REQUESTS_TRANSPORT_RESPONSES, request_and_responses_product, create_transport_response +from rest_client_async import AsyncMockRestClient +from azure.core.pipeline._tools import is_rest from azure.core.polling import async_poller, AsyncLROPoller from azure.core.exceptions import DecodeError, HttpResponseError from azure.core import AsyncPipelineClient from azure.core.pipeline import PipelineResponse, AsyncPipeline, PipelineContext from azure.core.pipeline.transport import AsyncioRequestsTransportResponse, AsyncHttpTransport - from azure.core.polling.base_polling import LROBasePolling from azure.core.polling.async_base_polling import ( AsyncLROBasePolling, ) -from utils import ASYNCIO_REQUESTS_TRANSPORT_RESPONSES, request_and_responses_product, create_transport_response -from rest_client_async import AsyncMockRestClient class SimpleResource: diff --git a/sdk/core/azure-core/tests/async_tests/test_basic_transport_async.py b/sdk/core/azure-core/tests/async_tests/test_basic_transport_async.py index c2e0880aee81..652bbefb3221 100644 --- a/sdk/core/azure-core/tests/async_tests/test_basic_transport_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_basic_transport_async.py @@ -4,13 +4,14 @@ # license information. # ------------------------------------------------------------------------- -import pytest import sys import asyncio -from packaging.version import Version from unittest import mock +import pytest +from packaging.version import Version import aiohttp +from utils import HTTP_REQUESTS, request_and_responses_product from azure.core.pipeline.transport import ( AsyncHttpResponse as PipelineTransportAsyncHttpResponse, @@ -31,8 +32,6 @@ ServiceResponseTimeoutError, ) -from utils import HTTP_REQUESTS, request_and_responses_product - # transport = mock.MagicMock(spec=AsyncHttpTransport) # MagicMock support async cxt manager only after 3.8 diff --git a/sdk/core/azure-core/tests/async_tests/test_content_length_checking_async.py b/sdk/core/azure-core/tests/async_tests/test_content_length_checking_async.py index 726c4baf32ed..11033180be64 100644 --- a/sdk/core/azure-core/tests/async_tests/test_content_length_checking_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_content_length_checking_async.py @@ -4,13 +4,14 @@ # Licensed under the MIT License. See LICENSE.txt in the project root for # license information. # ------------------------------------------------------------------------- +import pytest + from azure.core.pipeline import AsyncPipeline from azure.core.pipeline.transport import ( HttpRequest, ) from azure.core import AsyncPipelineClient from azure.core.exceptions import IncompleteReadError -import pytest @pytest.mark.asyncio diff --git a/sdk/core/azure-core/tests/async_tests/test_http_logging_policy_async.py b/sdk/core/azure-core/tests/async_tests/test_http_logging_policy_async.py index f79405225b4b..4c4d62d751bc 100644 --- a/sdk/core/azure-core/tests/async_tests/test_http_logging_policy_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_http_logging_policy_async.py @@ -6,14 +6,16 @@ import logging import types -import pytest import sys from unittest.mock import Mock + +import pytest +from utils import HTTP_RESPONSES, request_and_responses_product, create_http_response + from azure.core.pipeline import PipelineResponse, PipelineRequest, PipelineContext from azure.core.pipeline.policies import ( HttpLoggingPolicy, ) -from utils import HTTP_RESPONSES, request_and_responses_product, create_http_response @pytest.mark.parametrize("http_request,http_response", request_and_responses_product(HTTP_RESPONSES)) diff --git a/sdk/core/azure-core/tests/async_tests/test_paging_async.py b/sdk/core/azure-core/tests/async_tests/test_paging_async.py index 3f372ddba8fe..a535faea7831 100644 --- a/sdk/core/azure-core/tests/async_tests/test_paging_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_paging_async.py @@ -26,11 +26,11 @@ from typing import AsyncIterator, TypeVar, List +import pytest + from azure.core.async_paging import AsyncItemPaged, AsyncList from azure.core.exceptions import HttpResponseError -import pytest - T = TypeVar("T") diff --git a/sdk/core/azure-core/tests/async_tests/test_pipeline_async.py b/sdk/core/azure-core/tests/async_tests/test_pipeline_async.py index 6fae18e8a4ad..ef90f325001d 100644 --- a/sdk/core/azure-core/tests/async_tests/test_pipeline_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_pipeline_async.py @@ -26,6 +26,11 @@ import sys from unittest.mock import Mock +import aiohttp +import trio +import pytest +from utils import HTTP_REQUESTS + from azure.core.credentials import AccessToken from azure.core.pipeline import AsyncPipeline from azure.core.pipeline.policies import ( @@ -55,12 +60,6 @@ from azure.core import AsyncPipelineClient from azure.core.exceptions import AzureError -import aiohttp -import trio - -import pytest -from utils import HTTP_REQUESTS - try: from unittest.mock import AsyncMock, PropertyMock diff --git a/sdk/core/azure-core/tests/async_tests/test_request_asyncio.py b/sdk/core/azure-core/tests/async_tests/test_request_asyncio.py index 753c0e146acb..84543324a153 100644 --- a/sdk/core/azure-core/tests/async_tests/test_request_asyncio.py +++ b/sdk/core/azure-core/tests/async_tests/test_request_asyncio.py @@ -5,10 +5,11 @@ # ------------------------------------------------------------------------- import json -from azure.core.pipeline.transport import AsyncioRequestsTransport +import pytest from utils import HTTP_REQUESTS + +from azure.core.pipeline.transport import AsyncioRequestsTransport from azure.core.pipeline._tools import is_rest -import pytest @pytest.mark.asyncio diff --git a/sdk/core/azure-core/tests/async_tests/test_request_trio.py b/sdk/core/azure-core/tests/async_tests/test_request_trio.py index 668e07288824..678de9aef187 100644 --- a/sdk/core/azure-core/tests/async_tests/test_request_trio.py +++ b/sdk/core/azure-core/tests/async_tests/test_request_trio.py @@ -5,11 +5,11 @@ # ------------------------------------------------------------------------- import json -from azure.core.pipeline.transport import TrioRequestsTransport +import pytest from utils import HTTP_REQUESTS -from azure.core.pipeline._tools import is_rest -import pytest +from azure.core.pipeline.transport import TrioRequestsTransport +from azure.core.pipeline._tools import is_rest @pytest.mark.trio diff --git a/sdk/core/azure-core/tests/async_tests/test_rest_asyncio_transport.py b/sdk/core/azure-core/tests/async_tests/test_rest_asyncio_transport.py index b487b71b1d2e..539ead5b2c8a 100644 --- a/sdk/core/azure-core/tests/async_tests/test_rest_asyncio_transport.py +++ b/sdk/core/azure-core/tests/async_tests/test_rest_asyncio_transport.py @@ -3,15 +3,15 @@ # Licensed under the MIT License. See LICENSE.txt in the project root for # license information. # ------------------------------------------------------------------------- -from azure.core.pipeline.transport import AsyncioRequestsTransport -from azure.core.rest import HttpRequest -from azure.core.rest._requests_asyncio import RestAsyncioRequestsTransportResponse -from rest_client_async import AsyncMockRestClient - import pytest import pytest_asyncio +from rest_client_async import AsyncMockRestClient from utils import readonly_checks +from azure.core.pipeline.transport import AsyncioRequestsTransport +from azure.core.rest import HttpRequest +from azure.core.rest._requests_asyncio import RestAsyncioRequestsTransportResponse + @pytest_asyncio.fixture async def client(port): diff --git a/sdk/core/azure-core/tests/async_tests/test_rest_context_manager_async.py b/sdk/core/azure-core/tests/async_tests/test_rest_context_manager_async.py index 9bb5c762bc24..b727e0fc6e9e 100644 --- a/sdk/core/azure-core/tests/async_tests/test_rest_context_manager_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_rest_context_manager_async.py @@ -4,11 +4,12 @@ # Licensed under the MIT License. See LICENSE.txt in the project root for # license information. # ------------------------------------------------------------------------- -from azure.core.exceptions import ResponseNotReadError import pytest -from azure.core.rest import HttpRequest from rest_client_async import AsyncMockRestClient +from azure.core.exceptions import ResponseNotReadError +from azure.core.rest import HttpRequest + @pytest.mark.asyncio async def test_normal_call(client): diff --git a/sdk/core/azure-core/tests/async_tests/test_rest_headers_async.py b/sdk/core/azure-core/tests/async_tests/test_rest_headers_async.py index a9535add1881..47dac2c21476 100644 --- a/sdk/core/azure-core/tests/async_tests/test_rest_headers_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_rest_headers_async.py @@ -4,10 +4,12 @@ # Licensed under the MIT License. See LICENSE.txt in the project root for # license information. # ------------------------------------------------------------------------- -import pytest import platform -from azure.core.rest import HttpRequest + +import pytest import aiohttp + +from azure.core.rest import HttpRequest from azure.core.rest._aiohttp import RestAioHttpTransportResponse # flask returns these response headers, which we don't really need for these following tests diff --git a/sdk/core/azure-core/tests/async_tests/test_rest_http_request_async.py b/sdk/core/azure-core/tests/async_tests/test_rest_http_request_async.py index dfe0b6a3c436..483399a05200 100644 --- a/sdk/core/azure-core/tests/async_tests/test_rest_http_request_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_rest_http_request_async.py @@ -6,11 +6,13 @@ # NOTE: These tests are heavily inspired from the httpx test suite: https://github.com/encode/httpx/tree/master/tests # Thank you httpx for your wonderful tests! -import pytest -from azure.core.rest import HttpRequest import collections.abc + +import pytest from utils import NamedIo +from azure.core.rest import HttpRequest + @pytest.fixture def assert_aiterator_body(): diff --git a/sdk/core/azure-core/tests/async_tests/test_rest_http_response_async.py b/sdk/core/azure-core/tests/async_tests/test_rest_http_response_async.py index 243d41e3160c..2f5ca80e54d2 100644 --- a/sdk/core/azure-core/tests/async_tests/test_rest_http_response_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_rest_http_response_async.py @@ -7,12 +7,14 @@ # NOTE: These tests are heavily inspired from the httpx test suite: https://github.com/encode/httpx/tree/master/tests # Thank you httpx for your wonderful tests! import io -import pytest import zlib + +import pytest +from utils import readonly_checks + from azure.core.rest import HttpRequest, AsyncHttpResponse from azure.core.rest._aiohttp import RestAioHttpTransportResponse from azure.core.exceptions import HttpResponseError -from utils import readonly_checks @pytest.fixture diff --git a/sdk/core/azure-core/tests/async_tests/test_rest_response_backcompat_async.py b/sdk/core/azure-core/tests/async_tests/test_rest_response_backcompat_async.py index 518d17ff18ff..669641ebbb06 100644 --- a/sdk/core/azure-core/tests/async_tests/test_rest_response_backcompat_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_rest_response_backcompat_async.py @@ -5,13 +5,15 @@ # license information. # ------------------------------------------------------------------------- import sys + import pytest import pytest_asyncio +from rest_client_async import AsyncMockRestClient + from azure.core.pipeline.transport import HttpRequest as PipelineTransportHttpRequest from azure.core.rest import HttpRequest as RestHttpRequest from azure.core.pipeline import Pipeline from azure.core.pipeline.transport import AioHttpTransport, AsyncioRequestsTransport, TrioRequestsTransport -from rest_client_async import AsyncMockRestClient TRANSPORTS = [AioHttpTransport, AsyncioRequestsTransport] diff --git a/sdk/core/azure-core/tests/async_tests/test_rest_stream_responses_async.py b/sdk/core/azure-core/tests/async_tests/test_rest_stream_responses_async.py index 41994f73cc4b..2b9187c83546 100644 --- a/sdk/core/azure-core/tests/async_tests/test_rest_stream_responses_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_rest_stream_responses_async.py @@ -3,8 +3,9 @@ # Licensed under the MIT License. See LICENSE.txt in the project root for # license information. # ------------------------------------------------------------------------- -from azure.core.exceptions import HttpResponseError, ServiceRequestError import pytest + +from azure.core.exceptions import HttpResponseError, ServiceRequestError from azure.core.rest import HttpRequest from azure.core.exceptions import StreamClosedError, StreamConsumedError, ResponseNotReadError diff --git a/sdk/core/azure-core/tests/async_tests/test_rest_trio_transport.py b/sdk/core/azure-core/tests/async_tests/test_rest_trio_transport.py index a0462eb8ff91..ee16675cb2aa 100644 --- a/sdk/core/azure-core/tests/async_tests/test_rest_trio_transport.py +++ b/sdk/core/azure-core/tests/async_tests/test_rest_trio_transport.py @@ -3,12 +3,13 @@ # Licensed under the MIT License. See LICENSE.txt in the project root for # license information. # ------------------------------------------------------------------------- +import pytest +from rest_client_async import AsyncMockRestClient +from utils import readonly_checks + from azure.core.pipeline.transport import TrioRequestsTransport from azure.core.rest import HttpRequest from azure.core.rest._requests_trio import RestTrioRequestsTransportResponse -from rest_client_async import AsyncMockRestClient -from utils import readonly_checks -import pytest @pytest.fixture diff --git a/sdk/core/azure-core/tests/async_tests/test_retry_policy_async.py b/sdk/core/azure-core/tests/async_tests/test_retry_policy_async.py index 15d90b40b300..bf933f756ad8 100644 --- a/sdk/core/azure-core/tests/async_tests/test_retry_policy_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_retry_policy_async.py @@ -9,7 +9,15 @@ from cStringIO import StringIO as BytesIO import sys from unittest.mock import Mock +import tempfile +import os +import time +import asyncio +from itertools import product + import pytest +from utils import HTTP_REQUESTS + from azure.core.configuration import ConnectionConfiguration from azure.core.exceptions import ( AzureError, @@ -27,12 +35,6 @@ HttpResponse, AsyncHttpTransport, ) -import tempfile -import os -import time -import asyncio -from itertools import product -from utils import HTTP_REQUESTS def test_retry_code_class_variables(): diff --git a/sdk/core/azure-core/tests/async_tests/test_stream_generator_async.py b/sdk/core/azure-core/tests/async_tests/test_stream_generator_async.py index ad2e5d39cb02..0cb6a8630191 100644 --- a/sdk/core/azure-core/tests/async_tests/test_stream_generator_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_stream_generator_async.py @@ -2,7 +2,12 @@ # Copyright (c) Microsoft Corporation. # Licensed under the MIT License. # ------------------------------------ +from unittest import mock + import requests +import pytest +from utils import request_and_responses_product, ASYNC_HTTP_RESPONSES, create_http_response + from azure.core.pipeline.transport import ( AsyncHttpTransport, AsyncioRequestsTransportResponse, @@ -10,9 +15,6 @@ ) from azure.core.pipeline import AsyncPipeline, PipelineResponse from azure.core.pipeline.transport._aiohttp import AioHttpStreamDownloadGenerator -from unittest import mock -import pytest -from utils import request_and_responses_product, ASYNC_HTTP_RESPONSES, create_http_response @pytest.mark.asyncio diff --git a/sdk/core/azure-core/tests/async_tests/test_streaming_async.py b/sdk/core/azure-core/tests/async_tests/test_streaming_async.py index c16f96e41a48..325523a879d4 100644 --- a/sdk/core/azure-core/tests/async_tests/test_streaming_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_streaming_async.py @@ -25,10 +25,12 @@ # -------------------------------------------------------------------------- import os import zlib + import pytest +from utils import HTTP_REQUESTS + from azure.core import AsyncPipelineClient from azure.core.exceptions import DecodeError -from utils import HTTP_REQUESTS @pytest.mark.asyncio diff --git a/sdk/core/azure-core/tests/async_tests/test_testserver_async.py b/sdk/core/azure-core/tests/async_tests/test_testserver_async.py index bf294e54a105..e25e2f433e83 100644 --- a/sdk/core/azure-core/tests/async_tests/test_testserver_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_testserver_async.py @@ -24,9 +24,10 @@ # # -------------------------------------------------------------------------- import pytest -from azure.core.pipeline.transport import AioHttpTransport from utils import HTTP_REQUESTS +from azure.core.pipeline.transport import AioHttpTransport + """This file does a simple call to the testserver to make sure we can use the testserver""" diff --git a/sdk/core/azure-core/tests/async_tests/test_tracing_decorator_async.py b/sdk/core/azure-core/tests/async_tests/test_tracing_decorator_async.py index c67f47334f38..131d48bca696 100644 --- a/sdk/core/azure-core/tests/async_tests/test_tracing_decorator_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_tracing_decorator_async.py @@ -12,16 +12,16 @@ import time import pytest +from opentelemetry.trace import StatusCode as OtelStatusCode +from tracing_common import FakeSpan +from utils import HTTP_REQUESTS + from azure.core.pipeline import Pipeline, PipelineResponse from azure.core.pipeline.policies import HTTPPolicy from azure.core.pipeline.transport import HttpTransport from azure.core.settings import settings from azure.core.tracing import SpanKind from azure.core.tracing.decorator_async import distributed_trace_async -from opentelemetry.trace import StatusCode as OtelStatusCode - -from tracing_common import FakeSpan -from utils import HTTP_REQUESTS class MockClient: diff --git a/sdk/core/azure-core/tests/async_tests/test_tracing_live_async.py b/sdk/core/azure-core/tests/async_tests/test_tracing_live_async.py index ac006424e4a3..f04519c4c089 100644 --- a/sdk/core/azure-core/tests/async_tests/test_tracing_live_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_tracing_live_async.py @@ -2,15 +2,16 @@ # Copyright (c) Microsoft Corporation. # Licensed under the MIT License. # ------------------------------------ -import pytest import os from typing import Any -from azure.storage.blob.aio import BlobServiceClient +import pytest from opentelemetry.trace import SpanKind, StatusCode from opentelemetry.sdk.trace import ReadableSpan from devtools_testutils import get_credential +from azure.storage.blob.aio import BlobServiceClient + class TestTracingAsync: """Test class for validating async distributed tracing functionality.""" diff --git a/sdk/core/azure-core/tests/async_tests/test_tracing_policy_async.py b/sdk/core/azure-core/tests/async_tests/test_tracing_policy_async.py index 461f86c574c4..05e589de92af 100644 --- a/sdk/core/azure-core/tests/async_tests/test_tracing_policy_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_tracing_policy_async.py @@ -5,6 +5,9 @@ """Tests for the distributed tracing policy in an async pipeline.""" import pytest +from tracing_common import FakeSpan +from utils import HTTP_REQUESTS + from azure.core.pipeline import AsyncPipeline from azure.core.pipeline.policies import AsyncRetryPolicy, DistributedTracingPolicy from azure.core.pipeline.transport import ( @@ -12,9 +15,6 @@ AsyncHttpTransport, ) -from tracing_common import FakeSpan -from utils import HTTP_REQUESTS - class MockTransport(AsyncHttpTransport): def __init__(self): diff --git a/sdk/core/azure-core/tests/async_tests/test_universal_http_async.py b/sdk/core/azure-core/tests/async_tests/test_universal_http_async.py index a57a191e23ba..b62c3e847775 100644 --- a/sdk/core/azure-core/tests/async_tests/test_universal_http_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_universal_http_async.py @@ -23,18 +23,17 @@ # THE SOFTWARE. # # -------------------------------------------------------------------------- +import aiohttp +import trio +import pytest +from utils import HTTP_REQUESTS, AIOHTTP_TRANSPORT_RESPONSES, create_transport_response + from azure.core.pipeline.transport import ( AioHttpTransport, AioHttpTransportResponse, AsyncioRequestsTransport, TrioRequestsTransport, ) - -import aiohttp -import trio - -import pytest -from utils import HTTP_REQUESTS, AIOHTTP_TRANSPORT_RESPONSES, create_transport_response from azure.core.pipeline._tools import is_rest diff --git a/sdk/core/azure-core/tests/rest_client.py b/sdk/core/azure-core/tests/rest_client.py index 2b00d16ba947..68751bdbdd1b 100644 --- a/sdk/core/azure-core/tests/rest_client.py +++ b/sdk/core/azure-core/tests/rest_client.py @@ -23,10 +23,11 @@ # IN THE SOFTWARE. # # -------------------------------------------------------------------------- +from copy import deepcopy + from azure.core.pipeline import policies from azure.core.configuration import Configuration from azure.core import PipelineClient -from copy import deepcopy class TestRestClientConfiguration(Configuration): diff --git a/sdk/core/azure-core/tests/test_authentication.py b/sdk/core/azure-core/tests/test_authentication.py index 80ceb98bbe65..cd4d85160b6b 100644 --- a/sdk/core/azure-core/tests/test_authentication.py +++ b/sdk/core/azure-core/tests/test_authentication.py @@ -7,7 +7,12 @@ import base64 import time from itertools import product +from unittest.mock import Mock, patch + from requests import Response +from utils import HTTP_REQUESTS +import pytest + import azure.core from azure.core.credentials import ( AccessToken, @@ -33,11 +38,6 @@ MAX_REFRESH_JITTER_SECONDS, _should_refresh_token, ) -from utils import HTTP_REQUESTS - -import pytest - -from unittest.mock import Mock, patch @pytest.mark.parametrize("http_request", HTTP_REQUESTS) diff --git a/sdk/core/azure-core/tests/test_base_polling.py b/sdk/core/azure-core/tests/test_base_polling.py index ac5c9b2dcc23..f70516e2b453 100644 --- a/sdk/core/azure-core/tests/test_base_polling.py +++ b/sdk/core/azure-core/tests/test_base_polling.py @@ -38,6 +38,8 @@ import pytest from requests import Request, Response +from utils import request_and_responses_product, REQUESTS_TRANSPORT_RESPONSES, create_transport_response, HTTP_REQUESTS +from rest_client import MockRestClient from azure.core.polling import LROPoller from azure.core.exceptions import DecodeError, HttpResponseError @@ -46,9 +48,7 @@ from azure.core.pipeline.transport import HttpTransport from azure.core.polling.base_polling import LROBasePolling, OperationResourcePolling -from utils import request_and_responses_product, REQUESTS_TRANSPORT_RESPONSES, create_transport_response, HTTP_REQUESTS from azure.core.pipeline._tools import is_rest -from rest_client import MockRestClient class SimpleResource: diff --git a/sdk/core/azure-core/tests/test_basic_transport.py b/sdk/core/azure-core/tests/test_basic_transport.py index 2803e791d4ea..716a1ae0522a 100644 --- a/sdk/core/azure-core/tests/test_basic_transport.py +++ b/sdk/core/azure-core/tests/test_basic_transport.py @@ -6,13 +6,19 @@ from http.client import HTTPConnection from collections import OrderedDict import logging -import pytest from unittest import mock from socket import timeout as SocketTimeout +import pytest from urllib3.util import connection as urllib_connection from urllib3.response import HTTPResponse as UrllibResponse from urllib3.connection import HTTPConnection as UrllibConnection +from utils import ( + HTTP_REQUESTS, + request_and_responses_product, + HTTP_CLIENT_TRANSPORT_RESPONSES, + create_transport_response, +) from azure.core.rest._http_response_impl import HttpResponseImpl as RestHttpResponseImpl from azure.core.pipeline._tools import is_rest @@ -28,13 +34,6 @@ ServiceResponseTimeoutError, ) -from utils import ( - HTTP_REQUESTS, - request_and_responses_product, - HTTP_CLIENT_TRANSPORT_RESPONSES, - create_transport_response, -) - class PipelineTransportMockResponse(PipelineTransportHttpResponse): def __init__(self, request, body, content_type): diff --git a/sdk/core/azure-core/tests/test_content_length_checking.py b/sdk/core/azure-core/tests/test_content_length_checking.py index 7cdbd8f70c2a..75bbef71e33c 100644 --- a/sdk/core/azure-core/tests/test_content_length_checking.py +++ b/sdk/core/azure-core/tests/test_content_length_checking.py @@ -4,6 +4,8 @@ # Licensed under the MIT License. See LICENSE.txt in the project root for # license information. # ------------------------------------------------------------------------- +import pytest + from azure.core import PipelineClient from azure.core.pipeline import Pipeline from azure.core.pipeline.transport import ( @@ -11,7 +13,6 @@ RequestsTransport, ) from azure.core.exceptions import IncompleteReadError -import pytest def test_sync_transport_short_read_download_stream(port): diff --git a/sdk/core/azure-core/tests/test_custom_hook_policy.py b/sdk/core/azure-core/tests/test_custom_hook_policy.py index 402582d148a4..b8a83effa71d 100644 --- a/sdk/core/azure-core/tests/test_custom_hook_policy.py +++ b/sdk/core/azure-core/tests/test_custom_hook_policy.py @@ -7,11 +7,13 @@ from unittest import mock except ImportError: import mock + +import pytest +from utils import HTTP_REQUESTS + from azure.core import PipelineClient from azure.core.pipeline.policies import CustomHookPolicy, UserAgentPolicy from azure.core.pipeline.transport import HttpTransport -import pytest -from utils import HTTP_REQUESTS @pytest.mark.parametrize("http_request", HTTP_REQUESTS) diff --git a/sdk/core/azure-core/tests/test_error_map.py b/sdk/core/azure-core/tests/test_error_map.py index 51422493d71e..376ad63da9eb 100644 --- a/sdk/core/azure-core/tests/test_error_map.py +++ b/sdk/core/azure-core/tests/test_error_map.py @@ -24,13 +24,14 @@ # # -------------------------------------------------------------------------- import pytest +from utils import request_and_responses_product, create_http_response, HTTP_RESPONSES + from azure.core.exceptions import ( ResourceNotFoundError, ResourceExistsError, map_error, ErrorMap, ) -from utils import request_and_responses_product, create_http_response, HTTP_RESPONSES @pytest.mark.parametrize("http_request,http_response", request_and_responses_product(HTTP_RESPONSES)) diff --git a/sdk/core/azure-core/tests/test_exceptions.py b/sdk/core/azure-core/tests/test_exceptions.py index 71db780dae6d..619e6c0f6df1 100644 --- a/sdk/core/azure-core/tests/test_exceptions.py +++ b/sdk/core/azure-core/tests/test_exceptions.py @@ -23,11 +23,13 @@ # THE SOFTWARE. # # -------------------------------------------------------------------------- -import pytest import json -import requests from unittest.mock import Mock +import pytest +import requests +from utils import HTTP_REQUESTS + # module under test from azure.core.exceptions import ( HttpResponseError, @@ -39,7 +41,6 @@ from azure.core.pipeline.transport import RequestsTransportResponse from azure.core.pipeline.transport._base import _HttpResponseBase as PipelineTransportHttpResponseBase from azure.core.rest._http_response_impl import _HttpResponseBaseImpl as RestHttpResponseBase -from utils import HTTP_REQUESTS class PipelineTransportMockResponse(PipelineTransportHttpResponseBase): diff --git a/sdk/core/azure-core/tests/test_http_logging_policy.py b/sdk/core/azure-core/tests/test_http_logging_policy.py index 6f93341a2c0f..747af68de8ec 100644 --- a/sdk/core/azure-core/tests/test_http_logging_policy.py +++ b/sdk/core/azure-core/tests/test_http_logging_policy.py @@ -3,7 +3,6 @@ # Licensed under the MIT License. # ------------------------------------ """Tests for the HttpLoggingPolicy.""" -import pytest import logging import types @@ -11,11 +10,14 @@ from unittest.mock import Mock except ImportError: # python < 3.3 from mock import Mock # type: ignore + +import pytest +from utils import HTTP_RESPONSES, create_http_response, request_and_responses_product + from azure.core.pipeline import PipelineResponse, PipelineRequest, PipelineContext from azure.core.pipeline.policies import ( HttpLoggingPolicy, ) -from utils import HTTP_RESPONSES, create_http_response, request_and_responses_product from azure.core.pipeline._tools import is_rest diff --git a/sdk/core/azure-core/tests/test_messaging_cloud_event.py b/sdk/core/azure-core/tests/test_messaging_cloud_event.py index 2148c6271908..b9ab2ccd2d0d 100644 --- a/sdk/core/azure-core/tests/test_messaging_cloud_event.py +++ b/sdk/core/azure-core/tests/test_messaging_cloud_event.py @@ -2,10 +2,11 @@ # Copyright (c) Microsoft Corporation. # Licensed under the MIT License. # ------------------------------------ -import pytest import uuid import datetime +import pytest + from azure.core.messaging import CloudEvent from azure.core.utils._utils import _convert_to_isoformat from azure.core.utils._messaging_shared import _get_json_content diff --git a/sdk/core/azure-core/tests/test_paging.py b/sdk/core/azure-core/tests/test_paging.py index 7057a75aee53..5a11bee3f32c 100644 --- a/sdk/core/azure-core/tests/test_paging.py +++ b/sdk/core/azure-core/tests/test_paging.py @@ -24,11 +24,11 @@ # # -------------------------------------------------------------------------- +import pytest + from azure.core.paging import ItemPaged from azure.core.exceptions import HttpResponseError -import pytest - class TestPaging(object): def test_basic_paging(self): diff --git a/sdk/core/azure-core/tests/test_pipeline.py b/sdk/core/azure-core/tests/test_pipeline.py index 8262a70827f9..a9a08695b794 100644 --- a/sdk/core/azure-core/tests/test_pipeline.py +++ b/sdk/core/azure-core/tests/test_pipeline.py @@ -25,7 +25,6 @@ # -------------------------------------------------------------------------- import json -import requests try: from io import BytesIO @@ -35,6 +34,8 @@ import sys import pytest +import requests +from utils import HTTP_REQUESTS, is_rest from azure.core.configuration import Configuration from azure.core.pipeline import Pipeline @@ -56,8 +57,6 @@ HttpTransport, RequestsTransport, ) -from utils import HTTP_REQUESTS, is_rest - from azure.core.exceptions import AzureError from azure.core.pipeline._base import cleanup_kwargs_for_transport diff --git a/sdk/core/azure-core/tests/test_request_id_policy.py b/sdk/core/azure-core/tests/test_request_id_policy.py index 960b344a6d88..3fe5ebeb5a0a 100644 --- a/sdk/core/azure-core/tests/test_request_id_policy.py +++ b/sdk/core/azure-core/tests/test_request_id_policy.py @@ -3,17 +3,18 @@ # Licensed under the MIT License. # ------------------------------------ """Tests for the request id policy.""" -from azure.core.pipeline.policies import RequestIdPolicy -from azure.core.pipeline import PipelineRequest, PipelineContext - try: from unittest import mock except ImportError: import mock from itertools import product + import pytest from utils import HTTP_REQUESTS +from azure.core.pipeline import PipelineRequest, PipelineContext +from azure.core.pipeline.policies import RequestIdPolicy + auto_request_id_values = (True, False, None) request_id_init_values = ("foo", None, "_unset") request_id_set_values = ("bar", None, "_unset") diff --git a/sdk/core/azure-core/tests/test_requests_universal.py b/sdk/core/azure-core/tests/test_requests_universal.py index 880c414598ea..1c7312db8c8a 100644 --- a/sdk/core/azure-core/tests/test_requests_universal.py +++ b/sdk/core/azure-core/tests/test_requests_universal.py @@ -24,10 +24,12 @@ # # -------------------------------------------------------------------------- import concurrent.futures + import requests.utils import pytest -from azure.core.pipeline.transport import RequestsTransport from utils import HTTP_REQUESTS, REQUESTS_TRANSPORT_RESPONSES, create_transport_response + +from azure.core.pipeline.transport import RequestsTransport from azure.core.pipeline._tools import is_rest diff --git a/sdk/core/azure-core/tests/test_rest_http_request.py b/sdk/core/azure-core/tests/test_rest_http_request.py index 7ad245d30bb2..9ca0cca03b93 100644 --- a/sdk/core/azure-core/tests/test_rest_http_request.py +++ b/sdk/core/azure-core/tests/test_rest_http_request.py @@ -8,7 +8,6 @@ # NOTE: These tests are heavily inspired from the httpx test suite: https://github.com/encode/httpx/tree/master/tests # Thank you httpx for your wonderful tests! import io -import pytest import sys import os @@ -17,13 +16,15 @@ except ImportError: import collections # type: ignore +import pytest +from rest_client import MockRestClient +from utils import NamedIo + from azure.core.configuration import Configuration from azure.core.rest import HttpRequest from azure.core.pipeline.policies import CustomHookPolicy, UserAgentPolicy, SansIOHTTPPolicy, RetryPolicy from azure.core.pipeline._tools import is_rest -from rest_client import MockRestClient from azure.core import PipelineClient -from utils import NamedIo @pytest.fixture diff --git a/sdk/core/azure-core/tests/test_rest_http_response.py b/sdk/core/azure-core/tests/test_rest_http_response.py index 0f3219517103..920b47cc15c0 100644 --- a/sdk/core/azure-core/tests/test_rest_http_response.py +++ b/sdk/core/azure-core/tests/test_rest_http_response.py @@ -10,12 +10,14 @@ # Thank you httpx for your wonderful tests! import io import sys +import xml.etree.ElementTree as ET + import pytest +from utils import readonly_checks + from azure.core.rest import HttpRequest, HttpResponse from azure.core.rest._requests_basic import RestRequestsTransportResponse from azure.core.exceptions import HttpResponseError -import xml.etree.ElementTree as ET -from utils import readonly_checks @pytest.fixture diff --git a/sdk/core/azure-core/tests/test_rest_request_backcompat.py b/sdk/core/azure-core/tests/test_rest_request_backcompat.py index d7fe102f47dc..b593ff461764 100644 --- a/sdk/core/azure-core/tests/test_rest_request_backcompat.py +++ b/sdk/core/azure-core/tests/test_rest_request_backcompat.py @@ -5,9 +5,11 @@ # license information. # ------------------------------------------------------------------------- import sys -import pytest import json import xml.etree.ElementTree as ET + +import pytest + from azure.core.pipeline.transport import HttpRequest as PipelineTransportHttpRequest from azure.core.rest import HttpRequest as RestHttpRequest diff --git a/sdk/core/azure-core/tests/test_retry_policy.py b/sdk/core/azure-core/tests/test_retry_policy.py index d2201144ac6b..617e57406396 100644 --- a/sdk/core/azure-core/tests/test_retry_policy.py +++ b/sdk/core/azure-core/tests/test_retry_policy.py @@ -3,12 +3,24 @@ # Licensed under the MIT License. # ------------------------------------ """Tests for the retry policy.""" +import tempfile +import os +import time +from itertools import product + try: from io import BytesIO except ImportError: from cStringIO import StringIO as BytesIO + +try: + from unittest.mock import Mock +except ImportError: + from mock import Mock + import pytest -from itertools import product +from utils import HTTP_REQUESTS, request_and_responses_product, HTTP_RESPONSES, create_http_response + from azure.core.configuration import ConnectionConfiguration from azure.core.exceptions import ( AzureError, @@ -25,15 +37,6 @@ from azure.core.pipeline.transport import ( HttpTransport, ) -import tempfile -import os -import time - -try: - from unittest.mock import Mock -except ImportError: - from mock import Mock -from utils import HTTP_REQUESTS, request_and_responses_product, HTTP_RESPONSES, create_http_response def test_retry_code_class_variables(): diff --git a/sdk/core/azure-core/tests/test_serialization.py b/sdk/core/azure-core/tests/test_serialization.py index 553f29f93b2e..ddb1a5499402 100644 --- a/sdk/core/azure-core/tests/test_serialization.py +++ b/sdk/core/azure-core/tests/test_serialization.py @@ -11,15 +11,6 @@ from typing import Any, Dict, List, Optional, Union, Type from io import BytesIO -from azure.core.serialization import ( - AzureJSONEncoder, - NULL, - as_attribute_dict, - get_backcompat_attr_name, - is_generated_model, - attribute_list, -) -from azure.core.exceptions import DeserializationError import pytest from modeltypes._utils.model_base import ( Model as HybridModel, @@ -31,6 +22,16 @@ from modeltypes._utils.serialization import Model as MsrestModel from modeltypes import models +from azure.core.serialization import ( + AzureJSONEncoder, + NULL, + as_attribute_dict, + get_backcompat_attr_name, + is_generated_model, + attribute_list, +) +from azure.core.exceptions import DeserializationError + def _expand_value(obj): try: diff --git a/sdk/core/azure-core/tests/test_settings.py b/sdk/core/azure-core/tests/test_settings.py index e3b187ee5897..0afb6f05d118 100644 --- a/sdk/core/azure-core/tests/test_settings.py +++ b/sdk/core/azure-core/tests/test_settings.py @@ -26,10 +26,11 @@ import logging import os import sys -import pytest from typing import NamedTuple from unittest.mock import patch, MagicMock +import pytest + # module under test import azure.core.settings as m from azure.core import AzureClouds diff --git a/sdk/core/azure-core/tests/test_stream_generator.py b/sdk/core/azure-core/tests/test_stream_generator.py index e9ea512d0942..805b9d0d74c7 100644 --- a/sdk/core/azure-core/tests/test_stream_generator.py +++ b/sdk/core/azure-core/tests/test_stream_generator.py @@ -2,19 +2,12 @@ # Copyright (c) Microsoft Corporation. # Licensed under the MIT License. # ------------------------------------ -import requests -from azure.core.pipeline.transport import ( - HttpTransport, - RequestsTransport, -) -from azure.core.pipeline import Pipeline, PipelineResponse -from azure.core.pipeline.transport._requests_basic import StreamDownloadGenerator -from azure.core.exceptions import ServiceResponseError - try: from unittest import mock except ImportError: import mock + +import requests import pytest from utils import ( HTTP_RESPONSES, @@ -24,6 +17,14 @@ request_and_responses_product, ) +from azure.core.pipeline.transport import ( + HttpTransport, + RequestsTransport, +) +from azure.core.pipeline import Pipeline, PipelineResponse +from azure.core.pipeline.transport._requests_basic import StreamDownloadGenerator +from azure.core.exceptions import ServiceResponseError + @pytest.mark.parametrize("http_request,http_response", request_and_responses_product(HTTP_RESPONSES)) def test_connection_error_response(http_request, http_response): diff --git a/sdk/core/azure-core/tests/test_streaming.py b/sdk/core/azure-core/tests/test_streaming.py index 76a764a03c2f..c90a227b9d2c 100644 --- a/sdk/core/azure-core/tests/test_streaming.py +++ b/sdk/core/azure-core/tests/test_streaming.py @@ -24,11 +24,12 @@ # # -------------------------------------------------------------------------- import pytest +from utils import HTTP_REQUESTS + from azure.core.pipeline.transport import RequestsTransport from azure.core import PipelineClient from azure.core.exceptions import DecodeError from azure.core.pipeline.transport import RequestsTransport -from utils import HTTP_REQUESTS @pytest.mark.parametrize("http_request", HTTP_REQUESTS) diff --git a/sdk/core/azure-core/tests/test_testserver.py b/sdk/core/azure-core/tests/test_testserver.py index 507c08ae1156..65a5cdd3b9a2 100644 --- a/sdk/core/azure-core/tests/test_testserver.py +++ b/sdk/core/azure-core/tests/test_testserver.py @@ -23,9 +23,10 @@ # THE SOFTWARE. # # -------------------------------------------------------------------------- -from azure.core.pipeline.transport import RequestsTransport -from utils import HTTP_REQUESTS import pytest +from utils import HTTP_REQUESTS + +from azure.core.pipeline.transport import RequestsTransport """This file does a simple call to the testserver to make sure we can use the testserver""" diff --git a/sdk/core/azure-core/tests/test_tracer_otel.py b/sdk/core/azure-core/tests/test_tracer_otel.py index 2d828eda46bd..7c36ef9d1106 100644 --- a/sdk/core/azure-core/tests/test_tracer_otel.py +++ b/sdk/core/azure-core/tests/test_tracer_otel.py @@ -9,11 +9,6 @@ import threading import pytest -from azure.core.instrumentation import get_tracer -from azure.core.tracing._models import SpanKind, Link -from azure.core.tracing.opentelemetry import OpenTelemetryTracer -from azure.core.tracing.common import with_current_context - from opentelemetry.trace import ( Tracer as OtelTracer, Span as OtelSpan, @@ -23,6 +18,11 @@ format_trace_id, ) +from azure.core.instrumentation import get_tracer +from azure.core.tracing._models import SpanKind, Link +from azure.core.tracing.opentelemetry import OpenTelemetryTracer +from azure.core.tracing.common import with_current_context + def test_tracer(tracing_helper): """Test basic usage of a Instrumentation.""" diff --git a/sdk/core/azure-core/tests/test_tracing_decorator.py b/sdk/core/azure-core/tests/test_tracing_decorator.py index 6bfbacb76ae0..efd77d9454c9 100644 --- a/sdk/core/azure-core/tests/test_tracing_decorator.py +++ b/sdk/core/azure-core/tests/test_tracing_decorator.py @@ -8,16 +8,16 @@ import time import pytest +from opentelemetry.trace import StatusCode as OtelStatusCode +from tracing_common import FakeSpan +from utils import HTTP_REQUESTS + from azure.core.pipeline import Pipeline, PipelineResponse from azure.core.pipeline.policies import HTTPPolicy from azure.core.pipeline.transport import HttpTransport from azure.core.settings import settings from azure.core.tracing import common, SpanKind from azure.core.tracing.decorator import distributed_trace -from opentelemetry.trace import StatusCode as OtelStatusCode - -from tracing_common import FakeSpan -from utils import HTTP_REQUESTS class MockClient: diff --git a/sdk/core/azure-core/tests/test_tracing_live.py b/sdk/core/azure-core/tests/test_tracing_live.py index 882f0bcc7a85..cc41e9b44d7d 100644 --- a/sdk/core/azure-core/tests/test_tracing_live.py +++ b/sdk/core/azure-core/tests/test_tracing_live.py @@ -2,14 +2,15 @@ # Copyright (c) Microsoft Corporation. # Licensed under the MIT License. # ------------------------------------ -import pytest import os -from azure.storage.blob import BlobServiceClient +import pytest from opentelemetry.trace import SpanKind, StatusCode from opentelemetry.sdk.trace import ReadableSpan from devtools_testutils import get_credential +from azure.storage.blob import BlobServiceClient + class TestTracing: diff --git a/sdk/core/azure-core/tests/test_tracing_policy.py b/sdk/core/azure-core/tests/test_tracing_policy.py index 81bb60b5c16a..7533b6315d95 100644 --- a/sdk/core/azure-core/tests/test_tracing_policy.py +++ b/sdk/core/azure-core/tests/test_tracing_policy.py @@ -8,18 +8,18 @@ import urllib from unittest import mock +import pytest +from opentelemetry.trace import format_span_id, format_trace_id +from opentelemetry.instrumentation.requests import RequestsInstrumentor +from utils import HTTP_RESPONSES, HTTP_REQUESTS, create_http_response, request_and_responses_product +from tracing_common import FakeSpan + from azure.core.pipeline import Pipeline, PipelineResponse, PipelineRequest, PipelineContext from azure.core.pipeline.policies import DistributedTracingPolicy, HttpLoggingPolicy, UserAgentPolicy, RetryPolicy from azure.core.pipeline.transport import HttpTransport, RequestsTransport from azure.core.settings import settings from azure.core.tracing._models import SpanKind from azure.core.tracing._abstract_span import HttpSpanMixin -import pytest -from opentelemetry.trace import format_span_id, format_trace_id -from opentelemetry.instrumentation.requests import RequestsInstrumentor - -from utils import HTTP_RESPONSES, HTTP_REQUESTS, create_http_response, request_and_responses_product -from tracing_common import FakeSpan class TestTracingPolicyPluginImplementation: diff --git a/sdk/core/azure-core/tests/test_universal_pipeline.py b/sdk/core/azure-core/tests/test_universal_pipeline.py index dfc3477afe24..3a874452151a 100644 --- a/sdk/core/azure-core/tests/test_universal_pipeline.py +++ b/sdk/core/azure-core/tests/test_universal_pipeline.py @@ -34,6 +34,15 @@ import requests import pytest +from utils import ( + HTTP_REQUESTS, + create_http_request, + HTTP_RESPONSES, + REQUESTS_TRANSPORT_RESPONSES, + create_http_response, + create_transport_response, + request_and_responses_product, +) from azure.core.exceptions import DecodeError, AzureError from azure.core.pipeline import Pipeline, PipelineResponse, PipelineRequest, PipelineContext @@ -45,15 +54,6 @@ RetryPolicy, HTTPPolicy, ) -from utils import ( - HTTP_REQUESTS, - create_http_request, - HTTP_RESPONSES, - REQUESTS_TRANSPORT_RESPONSES, - create_http_response, - create_transport_response, - request_and_responses_product, -) from azure.core.pipeline._tools import is_rest diff --git a/sdk/core/azure-core/tests/test_user_agent_policy.py b/sdk/core/azure-core/tests/test_user_agent_policy.py index f4121d7eeffa..454d4bcaa10c 100644 --- a/sdk/core/azure-core/tests/test_user_agent_policy.py +++ b/sdk/core/azure-core/tests/test_user_agent_policy.py @@ -3,16 +3,17 @@ # Licensed under the MIT License. # ------------------------------------ """Tests for the user agent policy.""" -from azure.core.pipeline.policies import UserAgentPolicy -from azure.core.pipeline import PipelineRequest, PipelineContext - try: from unittest import mock except ImportError: import mock + import pytest from utils import HTTP_REQUESTS +from azure.core.pipeline.policies import UserAgentPolicy +from azure.core.pipeline import PipelineRequest, PipelineContext + @pytest.mark.parametrize("http_request", HTTP_REQUESTS) def test_user_agent_policy(http_request): diff --git a/sdk/core/azure-core/tests/testserver_tests/coretestserver/coretestserver/__init__.py b/sdk/core/azure-core/tests/testserver_tests/coretestserver/coretestserver/__init__.py index be1150e5e768..941f174fe299 100644 --- a/sdk/core/azure-core/tests/testserver_tests/coretestserver/coretestserver/__init__.py +++ b/sdk/core/azure-core/tests/testserver_tests/coretestserver/coretestserver/__init__.py @@ -5,8 +5,9 @@ # license information. # ------------------------------------------------------------------------- -from flask import Flask, Response import os + +from flask import Flask, Response from .test_routes import ( basic_api, encoding_api, diff --git a/sdk/core/azure-core/tests/testserver_tests/coretestserver/coretestserver/test_routes/helpers.py b/sdk/core/azure-core/tests/testserver_tests/coretestserver/coretestserver/test_routes/helpers.py index 75a406d4242c..c675a40b941f 100644 --- a/sdk/core/azure-core/tests/testserver_tests/coretestserver/coretestserver/test_routes/helpers.py +++ b/sdk/core/azure-core/tests/testserver_tests/coretestserver/coretestserver/test_routes/helpers.py @@ -3,13 +3,14 @@ # Licensed under the MIT License. See LICENSE.txt in the project root for # license information. # ------------------------------------------------------------------------- +from urllib.parse import urlparse, urlunparse +import json + from flask import ( request, jsonify as flask_jsonify, ) -from urllib.parse import urlparse, urlunparse from .structures import CaseInsensitiveDict -import json ENV_HEADERS = ( "X-Varnish", diff --git a/sdk/core/azure-core/tests/tracing_common.py b/sdk/core/azure-core/tests/tracing_common.py index 879997e775a0..0c022cbd2f97 100644 --- a/sdk/core/azure-core/tests/tracing_common.py +++ b/sdk/core/azure-core/tests/tracing_common.py @@ -4,9 +4,10 @@ # ------------------------------------ """Fake implementation of AbstractSpan for tests.""" from contextlib import contextmanager -from azure.core.tracing import HttpSpanMixin, SpanKind from typing import Union, Sequence, Optional, Dict +from azure.core.tracing import HttpSpanMixin, SpanKind + AttributeValue = Union[ str, bool, diff --git a/sdk/core/azure-core/tests/utils.py b/sdk/core/azure-core/tests/utils.py index 1166d023528d..553447d78058 100644 --- a/sdk/core/azure-core/tests/utils.py +++ b/sdk/core/azure-core/tests/utils.py @@ -3,21 +3,25 @@ # Licensed under the MIT License. See LICENSE.txt in the project root for # license information. # ------------------------------------------------------------------------- -import pytest import types import io +import pytest + ############################## LISTS USED TO PARAMETERIZE TESTS ############################## from azure.core.rest import HttpRequest as RestHttpRequest from azure.core.pipeline.transport import HttpRequest as PipelineTransportHttpRequest from azure.core.pipeline._tools import is_rest +from azure.core.pipeline.transport import HttpResponse as PipelineTransportHttpResponse +from azure.core.rest._http_response_impl import HttpResponseImpl as RestHttpResponse +from azure.core.pipeline.transport._base import ( + HttpClientTransportResponse as PipelineTransportHttpClientTransportResponse, +) +from azure.core.rest._http_response_impl import RestHttpClientTransportResponse HTTP_REQUESTS = [PipelineTransportHttpRequest, RestHttpRequest] REQUESTS_TRANSPORT_RESPONSES = [] -from azure.core.pipeline.transport import HttpResponse as PipelineTransportHttpResponse -from azure.core.rest._http_response_impl import HttpResponseImpl as RestHttpResponse - HTTP_RESPONSES = [PipelineTransportHttpResponse, RestHttpResponse] ASYNC_HTTP_RESPONSES = [] @@ -38,11 +42,6 @@ except ImportError: pass -from azure.core.pipeline.transport._base import ( - HttpClientTransportResponse as PipelineTransportHttpClientTransportResponse, -) -from azure.core.rest._http_response_impl import RestHttpClientTransportResponse - HTTP_CLIENT_TRANSPORT_RESPONSES = [PipelineTransportHttpClientTransportResponse, RestHttpClientTransportResponse] ASYNCIO_REQUESTS_TRANSPORT_RESPONSES = [] From c1878ad1a06997e49e4e46bf2115dfd44265ab79 Mon Sep 17 00:00:00 2001 From: Kashif Khan Date: Fri, 31 Jul 2026 13:47:47 -0500 Subject: [PATCH 2/9] fix line too long pylint errors --- .../samples/example_shared_transport.py | 3 +- .../samples/example_shared_transport_async.py | 3 +- .../async_tests/test_basic_transport_async.py | 1 + .../azure-core/tests/perf_tests/_test_base.py | 9 ++- .../tests/perf_tests/update_entity_json.py | 5 +- .../azure-core/tests/test_basic_transport.py | 1 + .../tests/test_connection_string_parsing.py | 65 +++++++++++++++---- sdk/core/azure-core/tests/test_exceptions.py | 15 +++-- .../tests/test_messaging_cloud_event.py | 1 + .../tests/test_rest_http_request.py | 1 + sdk/core/azure-core/tests/test_utils.py | 1 + .../coretestserver/test_routes/errors.py | 1 + 12 files changed, 80 insertions(+), 26 deletions(-) diff --git a/sdk/core/azure-core/samples/example_shared_transport.py b/sdk/core/azure-core/samples/example_shared_transport.py index 68c01c437fe0..cd7ae90b2570 100644 --- a/sdk/core/azure-core/samples/example_shared_transport.py +++ b/sdk/core/azure-core/samples/example_shared_transport.py @@ -33,7 +33,8 @@ def shared_transport(): session = requests.Session() shared_transport = RequestsTransport( session=session, session_owner=False - ) # here we set session_owner to False to indicate that we don't want to close the session when the client is closed + ) # here we set session_owner to False to indicate that we don't want to + # close the session when the client is closed with shared_transport: blob_service_client1 = BlobServiceClient.from_connection_string( connection_string, diff --git a/sdk/core/azure-core/samples/example_shared_transport_async.py b/sdk/core/azure-core/samples/example_shared_transport_async.py index 14c2bc289000..8f298c8069dd 100644 --- a/sdk/core/azure-core/samples/example_shared_transport_async.py +++ b/sdk/core/azure-core/samples/example_shared_transport_async.py @@ -34,7 +34,8 @@ async def shared_transport_async(): session = aiohttp.ClientSession() shared_transport = AioHttpTransport( session=session, session_owner=False - ) # here we set session_owner to False to indicate that we don't want to close the session when the client is closed + ) # here we set session_owner to False to indicate that we don't want to + # close the session when the client is closed async with shared_transport: blob_service_client1 = BlobServiceClient.from_connection_string( connection_string, diff --git a/sdk/core/azure-core/tests/async_tests/test_basic_transport_async.py b/sdk/core/azure-core/tests/async_tests/test_basic_transport_async.py index 652bbefb3221..1e239a324a4f 100644 --- a/sdk/core/azure-core/tests/async_tests/test_basic_transport_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_basic_transport_async.py @@ -4,6 +4,7 @@ # license information. # ------------------------------------------------------------------------- +# pylint: disable=line-too-long,useless-suppression import sys import asyncio from unittest import mock diff --git a/sdk/core/azure-core/tests/perf_tests/_test_base.py b/sdk/core/azure-core/tests/perf_tests/_test_base.py index e5c1db3a918c..b76e3f067de7 100644 --- a/sdk/core/azure-core/tests/perf_tests/_test_base.py +++ b/sdk/core/azure-core/tests/perf_tests/_test_base.py @@ -119,7 +119,8 @@ def _build_sync_pipeline_client(self, auth_policy): policy = getattr(policies, p) except AttributeError as exc: raise ValueError( - f"Azure Core has no policy named {exc.name}. Please use policies from the following list: {policies.__all__}" + f"Azure Core has no policy named {exc.name}. " + f"Please use policies from the following list: {policies.__all__}" ) from exc sync_policies.append(policy(sdk_moniker=self.sdk_moniker)) sync_pipeline = Pipeline(transport=self.sync_transport(), policies=sync_policies) @@ -152,7 +153,8 @@ def _build_async_pipeline_client(self, auth_policy): policy = getattr(policies, p) except AttributeError as exc: raise ValueError( - f"Azure Core has no policy named {exc.name}. Please use policies from the following list: {policies.__all__}" + f"Azure Core has no policy named {exc.name}. " + f"Please use policies from the following list: {policies.__all__}" ) from exc async_policies.append(policy(sdk_moniker=self.sdk_moniker)) async_pipeline = AsyncPipeline(transport=self.async_transport(), policies=async_policies) @@ -182,7 +184,8 @@ def add_arguments(parser): "--transport", nargs="?", type=str, - help="""Underlying HttpTransport type. Defaults to `aiohttp` if async, `requests` if sync. Other possible values for async:\n""" + help="""Underlying HttpTransport type. Defaults to `aiohttp` if async, `requests` if sync. """ + """Other possible values for async:\n""" """ - `requests`\n""", default=None, ) diff --git a/sdk/core/azure-core/tests/perf_tests/update_entity_json.py b/sdk/core/azure-core/tests/perf_tests/update_entity_json.py index 80b6f401385b..3d705174e053 100644 --- a/sdk/core/azure-core/tests/perf_tests/update_entity_json.py +++ b/sdk/core/azure-core/tests/perf_tests/update_entity_json.py @@ -24,7 +24,10 @@ def __init__(self, arguments): self.base_entity = self.get_base_entity( UpdateEntityJSONTest.partition_key, UpdateEntityJSONTest.row_key, self.args.size ) - self.url = f"{self.account_endpoint}{self.table_name}(PartitionKey='{UpdateEntityJSONTest.partition_key}',RowKey='{UpdateEntityJSONTest.row_key}')" + self.url = ( + f"{self.account_endpoint}{self.table_name}" + f"(PartitionKey='{UpdateEntityJSONTest.partition_key}',RowKey='{UpdateEntityJSONTest.row_key}')" + ) async def global_setup(self): await super().global_setup() diff --git a/sdk/core/azure-core/tests/test_basic_transport.py b/sdk/core/azure-core/tests/test_basic_transport.py index 716a1ae0522a..1cd59b1f8e09 100644 --- a/sdk/core/azure-core/tests/test_basic_transport.py +++ b/sdk/core/azure-core/tests/test_basic_transport.py @@ -3,6 +3,7 @@ # Licensed under the MIT License. See LICENSE.txt in the project root for # license information. # ------------------------------------------------------------------------- +# pylint: disable=line-too-long,useless-suppression from http.client import HTTPConnection from collections import OrderedDict import logging diff --git a/sdk/core/azure-core/tests/test_connection_string_parsing.py b/sdk/core/azure-core/tests/test_connection_string_parsing.py index aa6471c402af..5f91e6eb0307 100644 --- a/sdk/core/azure-core/tests/test_connection_string_parsing.py +++ b/sdk/core/azure-core/tests/test_connection_string_parsing.py @@ -5,7 +5,10 @@ class TestCoreConnectionStringParser: # cSpell:disable def test_parsing_with_case_sensitive_keys_for_sensitive_conn_str(self, **kwargs): - conn_str = "Endpoint=XXXXENDPOINTXXXX;SharedAccessKeyName=XXXXPOLICYXXXX;SharedAccessKey=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" + conn_str = ( + "Endpoint=XXXXENDPOINTXXXX;SharedAccessKeyName=XXXXPOLICYXXXX;" + "SharedAccessKey=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" + ) parse_result = parse_connection_string(conn_str, True) assert parse_result["Endpoint"] == "XXXXENDPOINTXXXX" assert parse_result["SharedAccessKeyName"] == "XXXXPOLICYXXXX" @@ -18,21 +21,30 @@ def test_parsing_with_case_sensitive_keys_for_sensitive_conn_str(self, **kwargs) parse_result["sharedaccesskey"] def test_parsing_with_case_insensitive_keys_for_sensitive_conn_str(self, **kwargs): - conn_str = "Endpoint=XXXXENDPOINTXXXX;SharedAccessKeyName=XXXXPOLICYXXXX;SharedAccessKey=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" + conn_str = ( + "Endpoint=XXXXENDPOINTXXXX;SharedAccessKeyName=XXXXPOLICYXXXX;" + "SharedAccessKey=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" + ) parse_result = parse_connection_string(conn_str, False) assert parse_result["endpoint"] == "XXXXENDPOINTXXXX" assert parse_result["sharedaccesskeyname"] == "XXXXPOLICYXXXX" assert parse_result["sharedaccesskey"] == "THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" def test_parsing_with_case_insensitive_keys_for_insensitive_conn_str(self, **kwargs): - conn_str = "enDpoiNT=XXXXENDPOINTXXXX;sharedaccesskeyname=XXXXPOLICYXXXX;SHAREDACCESSKEY=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" + conn_str = ( + "enDpoiNT=XXXXENDPOINTXXXX;sharedaccesskeyname=XXXXPOLICYXXXX;" + "SHAREDACCESSKEY=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" + ) parse_result = parse_connection_string(conn_str, False) assert parse_result["endpoint"] == "XXXXENDPOINTXXXX" assert parse_result["sharedaccesskeyname"] == "XXXXPOLICYXXXX" assert parse_result["sharedaccesskey"] == "THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" def test_error_with_duplicate_case_sensitive_keys_for_sensitive_conn_str(self, **kwargs): - conn_str = "Endpoint=XXXXENDPOINTXXXX;Endpoint=XXXXENDPOINT2XXXX;SharedAccessKeyName=XXXXPOLICYXXXX;SharedAccessKey=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" + conn_str = ( + "Endpoint=XXXXENDPOINTXXXX;Endpoint=XXXXENDPOINT2XXXX;SharedAccessKeyName=XXXXPOLICYXXXX;" + "SharedAccessKey=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" + ) with pytest.raises(ValueError) as e: parse_result = parse_connection_string(conn_str, True) assert str(e.value) == "Connection string is either blank or malformed." @@ -44,7 +56,10 @@ def test_success_with_duplicate_case_sensitive_keys_for_sensitive_conn_str(self, assert parse_result["Endpoint"] == "XXXXENDPOINT2XXXX" def test_error_with_duplicate_case_insensitive_keys_for_insensitive_conn_str(self, **kwargs): - conn_str = "endPoinT=XXXXENDPOINTXXXX;eNdpOint=XXXXENDPOINT2XXXX;sharedaccesskeyname=XXXXPOLICYXXXX;SHAREDACCESSKEY=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" + conn_str = ( + "endPoinT=XXXXENDPOINTXXXX;eNdpOint=XXXXENDPOINT2XXXX;sharedaccesskeyname=XXXXPOLICYXXXX;" + "SHAREDACCESSKEY=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" + ) with pytest.raises(ValueError) as e: parse_result = parse_connection_string(conn_str, False) assert str(e.value) == "Duplicate key in connection string: endpoint" @@ -56,19 +71,28 @@ def test_error_with_malformed_conn_str(self): assert str(e.value) == "Connection string is either blank or malformed." def test_case_insensitive_clear_method(self): - conn_str = "enDpoiNT=XXXXENDPOINTXXXX;sharedaccesskeyname=XXXXPOLICYXXXX;SHAREDACCESSKEY=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" + conn_str = ( + "enDpoiNT=XXXXENDPOINTXXXX;sharedaccesskeyname=XXXXPOLICYXXXX;" + "SHAREDACCESSKEY=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" + ) parse_result = parse_connection_string(conn_str, False) parse_result.clear() assert len(parse_result) == 0 def test_case_insensitive_copy_method(self): - conn_str = "enDpoiNT=XXXXENDPOINTXXXX;sharedaccesskeyname=XXXXPOLICYXXXX;SHAREDACCESSKEY=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" + conn_str = ( + "enDpoiNT=XXXXENDPOINTXXXX;sharedaccesskeyname=XXXXPOLICYXXXX;" + "SHAREDACCESSKEY=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" + ) parse_result = parse_connection_string(conn_str, False) copied = parse_result.copy() assert copied == parse_result def test_case_insensitive_get_method(self): - conn_str = "Endpoint=XXXXENDPOINTXXXX;SharedAccessKeyName=XXXXPOLICYXXXX;SharedAccessKey=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" + conn_str = ( + "Endpoint=XXXXENDPOINTXXXX;SharedAccessKeyName=XXXXPOLICYXXXX;" + "SharedAccessKey=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" + ) parse_result = parse_connection_string(conn_str, False) assert parse_result.get("sharedaccesskeyname") == "XXXXPOLICYXXXX" assert parse_result.get("sharedaccesskey") == "THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" @@ -76,14 +100,20 @@ def test_case_insensitive_get_method(self): assert parse_result.get("accesskey", "XXothertestkeyXX=") == "XXothertestkeyXX=" def test_case_insensitive_keys_method(self): - conn_str = "enDpoiNT=XXXXENDPOINTXXXX;sharedaccesskeyname=XXXXPOLICYXXXX;SHAREDACCESSKEY=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" + conn_str = ( + "enDpoiNT=XXXXENDPOINTXXXX;sharedaccesskeyname=XXXXPOLICYXXXX;" + "SHAREDACCESSKEY=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" + ) parse_result = parse_connection_string(conn_str, False) keys = parse_result.keys() assert len(keys) == 3 assert "endpoint" in keys def test_case_insensitive_pop_method(self): - conn_str = "enDpoiNT=XXXXENDPOINTXXXX;sharedaccesskeyname=XXXXPOLICYXXXX;SHAREDACCESSKEY=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" + conn_str = ( + "enDpoiNT=XXXXENDPOINTXXXX;sharedaccesskeyname=XXXXPOLICYXXXX;" + "SHAREDACCESSKEY=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" + ) parse_result = parse_connection_string(conn_str, False) endpoint = parse_result.pop("endpoint") sharedaccesskey = parse_result.pop("sharedaccesskey") @@ -92,7 +122,10 @@ def test_case_insensitive_pop_method(self): assert sharedaccesskey == "THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" def test_case_insensitive_update_with_insensitive_method(self): - conn_str = "enDpoiNT=XXXXENDPOINTXXXX;sharedaccesskeyname=XXXXPOLICYXXXX;SHAREDACCESSKEY=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" + conn_str = ( + "enDpoiNT=XXXXENDPOINTXXXX;sharedaccesskeyname=XXXXPOLICYXXXX;" + "SHAREDACCESSKEY=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" + ) conn_str2 = "hostName=XXXXENDPOINTXXXX;ACCessKEy=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=;" parse_result_insensitive = parse_connection_string(conn_str, False) parse_result_insensitive2 = parse_connection_string(conn_str2, False) @@ -111,7 +144,10 @@ def test_case_insensitive_update_with_insensitive_method(self): assert len(parse_result_insensitive) == 5 def test_case_sensitive_update_with_insensitive_method(self): - conn_str = "enDpoiNT=XXXXENDPOINTXXXX;sharedaccesskeyname=XXXXPOLICYXXXX;SHAREDACCESSKEY=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" + conn_str = ( + "enDpoiNT=XXXXENDPOINTXXXX;sharedaccesskeyname=XXXXPOLICYXXXX;" + "SHAREDACCESSKEY=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" + ) conn_str2 = "hostName=XXXXENDPOINTXXXX;ACCessKEy=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=;" parse_result_insensitive = parse_connection_string(conn_str, False) parse_result_sensitive = parse_connection_string(conn_str2, True) @@ -123,7 +159,10 @@ def test_case_sensitive_update_with_insensitive_method(self): parse_result_sensitive["hostname"] def test_case_insensitive_values_method(self): - conn_str = "enDpoiNT=XXXXENDPOINTXXXX;sharedaccesskeyname=XXXXPOLICYXXXX;SHAREDACCESSKEY=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" + conn_str = ( + "enDpoiNT=XXXXENDPOINTXXXX;sharedaccesskeyname=XXXXPOLICYXXXX;" + "SHAREDACCESSKEY=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=" + ) parse_result = parse_connection_string(conn_str, False) values = parse_result.values() assert len(values) == 3 diff --git a/sdk/core/azure-core/tests/test_exceptions.py b/sdk/core/azure-core/tests/test_exceptions.py index 619e6c0f6df1..72e9d928027d 100644 --- a/sdk/core/azure-core/tests/test_exceptions.py +++ b/sdk/core/azure-core/tests/test_exceptions.py @@ -260,7 +260,8 @@ def test_broken_odata_details(self, mock_response): "code": "Conflict", "message": "The maximum number of Free ServerFarms allowed in a Subscription is 10.", "extendedCode": "59301", - "messageTemplate": "The maximum number of {0} ServerFarms allowed in a Subscription is {1}.", + "messageTemplate": "The maximum number of {0} ServerFarms allowed " + "in a Subscription is {1}.", "parameters": ["Free", "10"], "innerErrors": None, } @@ -292,9 +293,9 @@ def test_non_odatav4_error_body(self, client, http_request): response = client.send_request(request) with pytest.raises(HttpResponseError) as ex: response.raise_for_status() - assert ( - str(ex.value) - == 'Operation returned an invalid status \'BAD REQUEST\'\nContent: {"code": 400, "error": {"global": ["MY-ERROR-MESSAGE-THAT-IS-COMING-FROM-THE-API"]}}' + assert str(ex.value) == ( + "Operation returned an invalid status 'BAD REQUEST'\n" + 'Content: {"code": 400, "error": {"global": ["MY-ERROR-MESSAGE-THAT-IS-COMING-FROM-THE-API"]}}' ) @pytest.mark.parametrize("http_request", HTTP_REQUESTS) @@ -303,9 +304,9 @@ def test_malformed_json(self, client, http_request): response = client.send_request(request) with pytest.raises(HttpResponseError) as ex: response.raise_for_status() - assert ( - str(ex.value) - == 'Operation returned an invalid status \'BAD REQUEST\'\nContent: {"code": 400, "error": {"global": ["MY-ERROR-MESSAGE-THAT-IS-COMING-FROM-THE-API"]' + assert str(ex.value) == ( + "Operation returned an invalid status 'BAD REQUEST'\n" + 'Content: {"code": 400, "error": {"global": ["MY-ERROR-MESSAGE-THAT-IS-COMING-FROM-THE-API"]' ) @pytest.mark.parametrize("http_request", HTTP_REQUESTS) diff --git a/sdk/core/azure-core/tests/test_messaging_cloud_event.py b/sdk/core/azure-core/tests/test_messaging_cloud_event.py index b9ab2ccd2d0d..788c8b9719b6 100644 --- a/sdk/core/azure-core/tests/test_messaging_cloud_event.py +++ b/sdk/core/azure-core/tests/test_messaging_cloud_event.py @@ -2,6 +2,7 @@ # Copyright (c) Microsoft Corporation. # Licensed under the MIT License. # ------------------------------------ +# pylint: disable=line-too-long,useless-suppression import uuid import datetime diff --git a/sdk/core/azure-core/tests/test_rest_http_request.py b/sdk/core/azure-core/tests/test_rest_http_request.py index 9ca0cca03b93..2963cce33116 100644 --- a/sdk/core/azure-core/tests/test_rest_http_request.py +++ b/sdk/core/azure-core/tests/test_rest_http_request.py @@ -7,6 +7,7 @@ # NOTE: These tests are heavily inspired from the httpx test suite: https://github.com/encode/httpx/tree/master/tests # Thank you httpx for your wonderful tests! +# pylint: disable=line-too-long,useless-suppression import io import sys import os diff --git a/sdk/core/azure-core/tests/test_utils.py b/sdk/core/azure-core/tests/test_utils.py index 5247d65d67d1..8bf74de5e1fe 100644 --- a/sdk/core/azure-core/tests/test_utils.py +++ b/sdk/core/azure-core/tests/test_utils.py @@ -2,6 +2,7 @@ # Copyright (c) Microsoft Corporation. # Licensed under the MIT License. # ------------------------------------ +# pylint: disable=line-too-long,useless-suppression import sys from unittest.mock import patch diff --git a/sdk/core/azure-core/tests/testserver_tests/coretestserver/coretestserver/test_routes/errors.py b/sdk/core/azure-core/tests/testserver_tests/coretestserver/coretestserver/test_routes/errors.py index 87b274e1f6b7..44b38a5cf9b7 100644 --- a/sdk/core/azure-core/tests/testserver_tests/coretestserver/coretestserver/test_routes/errors.py +++ b/sdk/core/azure-core/tests/testserver_tests/coretestserver/coretestserver/test_routes/errors.py @@ -4,6 +4,7 @@ # Licensed under the MIT License. See LICENSE.txt in the project root for # license information. # ------------------------------------------------------------------------- +# pylint: disable=line-too-long,useless-suppression from flask import ( Response, Blueprint, From 6e0bd08faff714922f79cf1568b204f3c6574b7e Mon Sep 17 00:00:00 2001 From: Kashif Khan Date: Fri, 31 Jul 2026 14:17:47 -0500 Subject: [PATCH 3/9] fix unused imports --- sdk/core/azure-core/samples/test_example_sansio.py | 2 -- .../tests/async_tests/test_content_length_checking_async.py | 1 - sdk/core/azure-core/tests/async_tests/test_polling_async.py | 1 - .../tests/async_tests/test_rest_context_manager_async.py | 1 - .../azure-core/tests/async_tests/test_rest_headers_async.py | 3 --- .../tests/async_tests/test_rest_http_response_async.py | 1 - .../tests/async_tests/test_rest_response_backcompat_async.py | 1 - .../azure-core/tests/async_tests/test_retry_policy_async.py | 2 -- sdk/core/azure-core/tests/async_tests/test_streaming_async.py | 1 - .../azure-core/tests/async_tests/test_tracing_live_async.py | 1 - .../azure-core/tests/async_tests/test_universal_http_async.py | 1 - sdk/core/azure-core/tests/perf_tests/download_binary.py | 2 +- .../tests/specs_sdk/modeltypes/modeltypes/models/_patch.py | 2 +- sdk/core/azure-core/tests/test_basic_transport.py | 1 - sdk/core/azure-core/tests/test_content_length_checking.py | 2 -- sdk/core/azure-core/tests/test_http_logging_policy.py | 1 - sdk/core/azure-core/tests/test_rest_headers.py | 2 -- sdk/core/azure-core/tests/test_rest_http_request.py | 1 - sdk/core/azure-core/tests/test_rest_http_response.py | 1 - sdk/core/azure-core/tests/test_rest_request_backcompat.py | 1 - sdk/core/azure-core/tests/test_rest_response_backcompat.py | 1 - sdk/core/azure-core/tests/test_serialization.py | 2 -- sdk/core/azure-core/tests/test_settings.py | 1 - sdk/core/azure-core/tests/test_universal_pipeline.py | 1 - .../coretestserver/coretestserver/test_routes/headers.py | 2 +- 25 files changed, 3 insertions(+), 32 deletions(-) diff --git a/sdk/core/azure-core/samples/test_example_sansio.py b/sdk/core/azure-core/samples/test_example_sansio.py index c27aa9530b17..ce415db0a815 100644 --- a/sdk/core/azure-core/samples/test_example_sansio.py +++ b/sdk/core/azure-core/samples/test_example_sansio.py @@ -24,13 +24,11 @@ # # -------------------------------------------------------------------------- -import sys from azure.core.pipeline import PipelineRequest from azure.core.rest import HttpRequest, HttpResponse from azure.core import PipelineClient from azure.core.pipeline.policies import RedirectPolicy from azure.core.pipeline.policies import UserAgentPolicy -from azure.core.pipeline.policies import SansIOHTTPPolicy from azure.core.pipeline.policies import RequestIdPolicy diff --git a/sdk/core/azure-core/tests/async_tests/test_content_length_checking_async.py b/sdk/core/azure-core/tests/async_tests/test_content_length_checking_async.py index 11033180be64..290fc36e4bd7 100644 --- a/sdk/core/azure-core/tests/async_tests/test_content_length_checking_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_content_length_checking_async.py @@ -6,7 +6,6 @@ # ------------------------------------------------------------------------- import pytest -from azure.core.pipeline import AsyncPipeline from azure.core.pipeline.transport import ( HttpRequest, ) diff --git a/sdk/core/azure-core/tests/async_tests/test_polling_async.py b/sdk/core/azure-core/tests/async_tests/test_polling_async.py index 45f1227fbb7c..fdb41702973b 100644 --- a/sdk/core/azure-core/tests/async_tests/test_polling_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_polling_async.py @@ -24,7 +24,6 @@ # # -------------------------------------------------------------------------- import asyncio -import time try: from unittest import mock diff --git a/sdk/core/azure-core/tests/async_tests/test_rest_context_manager_async.py b/sdk/core/azure-core/tests/async_tests/test_rest_context_manager_async.py index b727e0fc6e9e..3932e6012f49 100644 --- a/sdk/core/azure-core/tests/async_tests/test_rest_context_manager_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_rest_context_manager_async.py @@ -5,7 +5,6 @@ # license information. # ------------------------------------------------------------------------- import pytest -from rest_client_async import AsyncMockRestClient from azure.core.exceptions import ResponseNotReadError from azure.core.rest import HttpRequest diff --git a/sdk/core/azure-core/tests/async_tests/test_rest_headers_async.py b/sdk/core/azure-core/tests/async_tests/test_rest_headers_async.py index 47dac2c21476..b911b242d084 100644 --- a/sdk/core/azure-core/tests/async_tests/test_rest_headers_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_rest_headers_async.py @@ -4,13 +4,10 @@ # Licensed under the MIT License. See LICENSE.txt in the project root for # license information. # ------------------------------------------------------------------------- -import platform import pytest -import aiohttp from azure.core.rest import HttpRequest -from azure.core.rest._aiohttp import RestAioHttpTransportResponse # flask returns these response headers, which we don't really need for these following tests RESPONSE_HEADERS_TO_IGNORE = [ diff --git a/sdk/core/azure-core/tests/async_tests/test_rest_http_response_async.py b/sdk/core/azure-core/tests/async_tests/test_rest_http_response_async.py index 2f5ca80e54d2..0c9df36a9e63 100644 --- a/sdk/core/azure-core/tests/async_tests/test_rest_http_response_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_rest_http_response_async.py @@ -7,7 +7,6 @@ # NOTE: These tests are heavily inspired from the httpx test suite: https://github.com/encode/httpx/tree/master/tests # Thank you httpx for your wonderful tests! import io -import zlib import pytest from utils import readonly_checks diff --git a/sdk/core/azure-core/tests/async_tests/test_rest_response_backcompat_async.py b/sdk/core/azure-core/tests/async_tests/test_rest_response_backcompat_async.py index 669641ebbb06..4fcd204ccf6d 100644 --- a/sdk/core/azure-core/tests/async_tests/test_rest_response_backcompat_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_rest_response_backcompat_async.py @@ -4,7 +4,6 @@ # Licensed under the MIT License. See LICENSE.txt in the project root for # license information. # ------------------------------------------------------------------------- -import sys import pytest import pytest_asyncio diff --git a/sdk/core/azure-core/tests/async_tests/test_retry_policy_async.py b/sdk/core/azure-core/tests/async_tests/test_retry_policy_async.py index bf933f756ad8..1a39ea769e4b 100644 --- a/sdk/core/azure-core/tests/async_tests/test_retry_policy_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_retry_policy_async.py @@ -7,11 +7,9 @@ from io import BytesIO except ImportError: from cStringIO import StringIO as BytesIO -import sys from unittest.mock import Mock import tempfile import os -import time import asyncio from itertools import product diff --git a/sdk/core/azure-core/tests/async_tests/test_streaming_async.py b/sdk/core/azure-core/tests/async_tests/test_streaming_async.py index 325523a879d4..1abce001072b 100644 --- a/sdk/core/azure-core/tests/async_tests/test_streaming_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_streaming_async.py @@ -23,7 +23,6 @@ # THE SOFTWARE. # # -------------------------------------------------------------------------- -import os import zlib import pytest diff --git a/sdk/core/azure-core/tests/async_tests/test_tracing_live_async.py b/sdk/core/azure-core/tests/async_tests/test_tracing_live_async.py index f04519c4c089..793e0709fa44 100644 --- a/sdk/core/azure-core/tests/async_tests/test_tracing_live_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_tracing_live_async.py @@ -3,7 +3,6 @@ # Licensed under the MIT License. # ------------------------------------ import os -from typing import Any import pytest from opentelemetry.trace import SpanKind, StatusCode diff --git a/sdk/core/azure-core/tests/async_tests/test_universal_http_async.py b/sdk/core/azure-core/tests/async_tests/test_universal_http_async.py index b62c3e847775..93dd0b9c0ecc 100644 --- a/sdk/core/azure-core/tests/async_tests/test_universal_http_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_universal_http_async.py @@ -30,7 +30,6 @@ from azure.core.pipeline.transport import ( AioHttpTransport, - AioHttpTransportResponse, AsyncioRequestsTransport, TrioRequestsTransport, ) diff --git a/sdk/core/azure-core/tests/perf_tests/download_binary.py b/sdk/core/azure-core/tests/perf_tests/download_binary.py index 43e455c249fc..3cc5cd131387 100644 --- a/sdk/core/azure-core/tests/perf_tests/download_binary.py +++ b/sdk/core/azure-core/tests/perf_tests/download_binary.py @@ -5,7 +5,7 @@ from time import time from wsgiref.handlers import format_date_time -from devtools_testutils.perfstress_tests import get_random_bytes, WriteStream +from devtools_testutils.perfstress_tests import get_random_bytes from azure.core.exceptions import ( HttpResponseError, diff --git a/sdk/core/azure-core/tests/specs_sdk/modeltypes/modeltypes/models/_patch.py b/sdk/core/azure-core/tests/specs_sdk/modeltypes/modeltypes/models/_patch.py index 20f2cffd6b76..0cda795a94b7 100644 --- a/sdk/core/azure-core/tests/specs_sdk/modeltypes/modeltypes/models/_patch.py +++ b/sdk/core/azure-core/tests/specs_sdk/modeltypes/modeltypes/models/_patch.py @@ -8,7 +8,7 @@ Follow our quickstart for examples: https://aka.ms/azsdk/python/dpcodegen/python/customize """ from typing import List, BinaryIO, Dict, Any, Optional -from datetime import date, datetime, time, timedelta, tzinfo +from datetime import date, datetime, time, timedelta from .._utils.model_base import Model as HybridModel, rest_field from .._utils.serialization import Model as MsrestModel diff --git a/sdk/core/azure-core/tests/test_basic_transport.py b/sdk/core/azure-core/tests/test_basic_transport.py index 1cd59b1f8e09..d57000da18ba 100644 --- a/sdk/core/azure-core/tests/test_basic_transport.py +++ b/sdk/core/azure-core/tests/test_basic_transport.py @@ -29,7 +29,6 @@ from azure.core.pipeline import Pipeline from azure.core.exceptions import ( HttpResponseError, - ServiceRequestError, ServiceResponseError, ServiceRequestTimeoutError, ServiceResponseTimeoutError, diff --git a/sdk/core/azure-core/tests/test_content_length_checking.py b/sdk/core/azure-core/tests/test_content_length_checking.py index 75bbef71e33c..33b0ee829a54 100644 --- a/sdk/core/azure-core/tests/test_content_length_checking.py +++ b/sdk/core/azure-core/tests/test_content_length_checking.py @@ -7,10 +7,8 @@ import pytest from azure.core import PipelineClient -from azure.core.pipeline import Pipeline from azure.core.pipeline.transport import ( HttpRequest, - RequestsTransport, ) from azure.core.exceptions import IncompleteReadError diff --git a/sdk/core/azure-core/tests/test_http_logging_policy.py b/sdk/core/azure-core/tests/test_http_logging_policy.py index 747af68de8ec..b689ed108e4b 100644 --- a/sdk/core/azure-core/tests/test_http_logging_policy.py +++ b/sdk/core/azure-core/tests/test_http_logging_policy.py @@ -18,7 +18,6 @@ from azure.core.pipeline.policies import ( HttpLoggingPolicy, ) -from azure.core.pipeline._tools import is_rest @pytest.mark.parametrize("http_request,http_response", request_and_responses_product(HTTP_RESPONSES)) diff --git a/sdk/core/azure-core/tests/test_rest_headers.py b/sdk/core/azure-core/tests/test_rest_headers.py index e5d170d1f738..cbabbc4a00d5 100644 --- a/sdk/core/azure-core/tests/test_rest_headers.py +++ b/sdk/core/azure-core/tests/test_rest_headers.py @@ -4,9 +4,7 @@ # license information. # ------------------------------------------------------------------------- import sys -from requests import Response import pytest -from azure.core.rest._requests_basic import RestRequestsTransportResponse # NOTE: These tests are heavily inspired from the httpx test suite: https://github.com/encode/httpx/tree/master/tests # Thank you httpx for your wonderful tests! diff --git a/sdk/core/azure-core/tests/test_rest_http_request.py b/sdk/core/azure-core/tests/test_rest_http_request.py index 2963cce33116..a4bd3670cf2e 100644 --- a/sdk/core/azure-core/tests/test_rest_http_request.py +++ b/sdk/core/azure-core/tests/test_rest_http_request.py @@ -9,7 +9,6 @@ # Thank you httpx for your wonderful tests! # pylint: disable=line-too-long,useless-suppression import io -import sys import os try: diff --git a/sdk/core/azure-core/tests/test_rest_http_response.py b/sdk/core/azure-core/tests/test_rest_http_response.py index 920b47cc15c0..29e2d8b193c6 100644 --- a/sdk/core/azure-core/tests/test_rest_http_response.py +++ b/sdk/core/azure-core/tests/test_rest_http_response.py @@ -9,7 +9,6 @@ # NOTE: These tests are heavily inspired from the httpx test suite: https://github.com/encode/httpx/tree/master/tests # Thank you httpx for your wonderful tests! import io -import sys import xml.etree.ElementTree as ET import pytest diff --git a/sdk/core/azure-core/tests/test_rest_request_backcompat.py b/sdk/core/azure-core/tests/test_rest_request_backcompat.py index b593ff461764..35cd77fa9ef2 100644 --- a/sdk/core/azure-core/tests/test_rest_request_backcompat.py +++ b/sdk/core/azure-core/tests/test_rest_request_backcompat.py @@ -4,7 +4,6 @@ # Licensed under the MIT License. See LICENSE.txt in the project root for # license information. # ------------------------------------------------------------------------- -import sys import json import xml.etree.ElementTree as ET diff --git a/sdk/core/azure-core/tests/test_rest_response_backcompat.py b/sdk/core/azure-core/tests/test_rest_response_backcompat.py index 938f4da48ce2..9d2e8d118663 100644 --- a/sdk/core/azure-core/tests/test_rest_response_backcompat.py +++ b/sdk/core/azure-core/tests/test_rest_response_backcompat.py @@ -4,7 +4,6 @@ # Licensed under the MIT License. See LICENSE.txt in the project root for # license information. # ------------------------------------------------------------------------- -import sys from rest_client import MockRestClient import pytest from azure.core.pipeline.transport import HttpRequest as PipelineTransportHttpRequest diff --git a/sdk/core/azure-core/tests/test_serialization.py b/sdk/core/azure-core/tests/test_serialization.py index ddb1a5499402..2f7a1f9c8da3 100644 --- a/sdk/core/azure-core/tests/test_serialization.py +++ b/sdk/core/azure-core/tests/test_serialization.py @@ -19,7 +19,6 @@ TYPE_HANDLER_REGISTRY, _deserialize, ) -from modeltypes._utils.serialization import Model as MsrestModel from modeltypes import models from azure.core.serialization import ( @@ -30,7 +29,6 @@ is_generated_model, attribute_list, ) -from azure.core.exceptions import DeserializationError def _expand_value(obj): diff --git a/sdk/core/azure-core/tests/test_settings.py b/sdk/core/azure-core/tests/test_settings.py index 0afb6f05d118..7ee412b132d4 100644 --- a/sdk/core/azure-core/tests/test_settings.py +++ b/sdk/core/azure-core/tests/test_settings.py @@ -25,7 +25,6 @@ # -------------------------------------------------------------------------- import logging import os -import sys from typing import NamedTuple from unittest.mock import patch, MagicMock diff --git a/sdk/core/azure-core/tests/test_universal_pipeline.py b/sdk/core/azure-core/tests/test_universal_pipeline.py index 3a874452151a..63a323ca6d3e 100644 --- a/sdk/core/azure-core/tests/test_universal_pipeline.py +++ b/sdk/core/azure-core/tests/test_universal_pipeline.py @@ -24,7 +24,6 @@ # THE SOFTWARE. # # -------------------------------------------------------------------------- -import logging import pickle try: diff --git a/sdk/core/azure-core/tests/testserver_tests/coretestserver/coretestserver/test_routes/headers.py b/sdk/core/azure-core/tests/testserver_tests/coretestserver/coretestserver/test_routes/headers.py index 92679dd0d2ca..0d25a985caa3 100644 --- a/sdk/core/azure-core/tests/testserver_tests/coretestserver/coretestserver/test_routes/headers.py +++ b/sdk/core/azure-core/tests/testserver_tests/coretestserver/coretestserver/test_routes/headers.py @@ -5,7 +5,7 @@ # license information. # ------------------------------------------------------------------------- -from flask import Response, Blueprint, request +from flask import Response, Blueprint headers_api = Blueprint("headers_api", __name__) From 8e3f9f22c858ea6d100b06dfff429fefb9f853c7 Mon Sep 17 00:00:00 2001 From: Kashif Khan Date: Fri, 31 Jul 2026 14:44:06 -0500 Subject: [PATCH 4/9] fix unsused imports --- sdk/core/azure-core/samples/test_example_async.py | 1 + sdk/core/azure-core/samples/test_example_policies.py | 1 - sdk/core/azure-core/samples/test_example_sansio.py | 3 +-- sdk/core/azure-core/samples/test_example_sync.py | 1 + .../azure-core/tests/async_tests/test_pipeline_async.py | 1 - .../azure-core/tests/async_tests/test_polling_async.py | 2 +- sdk/core/azure-core/tests/test_base_polling.py | 7 ------- sdk/core/azure-core/tests/test_pipeline.py | 1 - sdk/core/azure-core/tests/test_polling.py | 2 +- sdk/core/azure-core/tests/test_serialization.py | 2 +- sdk/core/azure-core/tests/test_streaming.py | 1 - 11 files changed, 6 insertions(+), 16 deletions(-) diff --git a/sdk/core/azure-core/samples/test_example_async.py b/sdk/core/azure-core/samples/test_example_async.py index 853e988d893f..e2b78c709b15 100644 --- a/sdk/core/azure-core/samples/test_example_async.py +++ b/sdk/core/azure-core/samples/test_example_async.py @@ -23,6 +23,7 @@ # THE SOFTWARE. # # -------------------------------------------------------------------------- +# pylint: disable=reimported from typing import Iterable, MutableSequence, Union import pytest diff --git a/sdk/core/azure-core/samples/test_example_policies.py b/sdk/core/azure-core/samples/test_example_policies.py index c1c3eea11ebb..9cb4739ebcb5 100644 --- a/sdk/core/azure-core/samples/test_example_policies.py +++ b/sdk/core/azure-core/samples/test_example_policies.py @@ -32,7 +32,6 @@ def callback(response): from azure.core.pipeline import Pipeline from azure.core.rest import HttpRequest - from azure.core.pipeline.policies import RedirectPolicy, UserAgentPolicy from azure.core.pipeline.transport import RequestsTransport from azure.core.pipeline.policies import CustomHookPolicy diff --git a/sdk/core/azure-core/samples/test_example_sansio.py b/sdk/core/azure-core/samples/test_example_sansio.py index ce415db0a815..7fb687b3c317 100644 --- a/sdk/core/azure-core/samples/test_example_sansio.py +++ b/sdk/core/azure-core/samples/test_example_sansio.py @@ -23,6 +23,7 @@ # THE SOFTWARE. # # -------------------------------------------------------------------------- +# pylint: disable=reimported from azure.core.pipeline import PipelineRequest from azure.core.rest import HttpRequest, HttpResponse @@ -60,8 +61,6 @@ def test_example_request_id_policy(): policies = [UserAgentPolicy("myuseragent"), RedirectPolicy()] # [START request_id_policy] - from azure.core.pipeline.policies import HeadersPolicy - request_id_policy = RequestIdPolicy() request_id_policy.set_request_id("azconfig-test") diff --git a/sdk/core/azure-core/samples/test_example_sync.py b/sdk/core/azure-core/samples/test_example_sync.py index 5f48b14ee3b0..f175eed80698 100644 --- a/sdk/core/azure-core/samples/test_example_sync.py +++ b/sdk/core/azure-core/samples/test_example_sync.py @@ -23,6 +23,7 @@ # THE SOFTWARE. # # -------------------------------------------------------------------------- +# pylint: disable=reimported from typing import Iterable, MutableSequence, Union from azure.core.pipeline import Pipeline from azure.core import PipelineClient diff --git a/sdk/core/azure-core/tests/async_tests/test_pipeline_async.py b/sdk/core/azure-core/tests/async_tests/test_pipeline_async.py index ef90f325001d..9fd7ced0c600 100644 --- a/sdk/core/azure-core/tests/async_tests/test_pipeline_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_pipeline_async.py @@ -41,7 +41,6 @@ AsyncRetryPolicy, AsyncRedirectPolicy, AsyncHTTPPolicy, - AsyncRetryPolicy, HttpLoggingPolicy, SensitiveHeaderCleanupPolicy, ) diff --git a/sdk/core/azure-core/tests/async_tests/test_polling_async.py b/sdk/core/azure-core/tests/async_tests/test_polling_async.py index fdb41702973b..6d608386a3d0 100644 --- a/sdk/core/azure-core/tests/async_tests/test_polling_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_polling_async.py @@ -33,7 +33,7 @@ import pytest from azure.core import AsyncPipelineClient -from azure.core.polling import * +from azure.core.polling import NoPolling, AsyncNoPolling, AsyncPollingMethod, AsyncLROPoller from azure.core.exceptions import ServiceResponseError # from msrest.serialization import Model diff --git a/sdk/core/azure-core/tests/test_base_polling.py b/sdk/core/azure-core/tests/test_base_polling.py index f70516e2b453..9351f9c68585 100644 --- a/sdk/core/azure-core/tests/test_base_polling.py +++ b/sdk/core/azure-core/tests/test_base_polling.py @@ -904,11 +904,8 @@ def test_post_check_patch(http_request): def test_continuation_token_with_non_json_serializable_data(port, deserialization_cb): """Test that continuation token gracefully handles non-JSON-serializable data like XML.""" - import base64 - import json import xml.etree.ElementTree as ET - from azure.core.polling.base_polling import LROBasePolling from azure.core.rest import HttpRequest client = MockRestClient(port) @@ -947,10 +944,6 @@ def test_continuation_token_with_non_json_serializable_data(port, deserializatio @pytest.mark.parametrize("http_request", HTTP_REQUESTS) def test_continuation_token_excludes_request_headers(port, http_request, deserialization_cb): """Test that continuation token does not include sensitive request headers for security.""" - import base64 - import json - - from azure.core.polling.base_polling import LROBasePolling client = MockRestClient(port) request = http_request( diff --git a/sdk/core/azure-core/tests/test_pipeline.py b/sdk/core/azure-core/tests/test_pipeline.py index a9a08695b794..b9d4eda269ac 100644 --- a/sdk/core/azure-core/tests/test_pipeline.py +++ b/sdk/core/azure-core/tests/test_pipeline.py @@ -49,7 +49,6 @@ RetryPolicy, HttpLoggingPolicy, HTTPPolicy, - SansIOHTTPPolicy, SensitiveHeaderCleanupPolicy, ) from azure.core.pipeline.transport._base import PipelineClientBase, _format_url_section diff --git a/sdk/core/azure-core/tests/test_polling.py b/sdk/core/azure-core/tests/test_polling.py index cdabd4575b90..f65605383b31 100644 --- a/sdk/core/azure-core/tests/test_polling.py +++ b/sdk/core/azure-core/tests/test_polling.py @@ -35,7 +35,7 @@ from azure.core import PipelineClient from azure.core.exceptions import ServiceResponseError -from azure.core.polling import * +from azure.core.polling import LROPoller, NoPolling, PollingMethod from azure.core.polling.base_polling import LROBasePolling, LocationPolling # from msrest.serialization import Model diff --git a/sdk/core/azure-core/tests/test_serialization.py b/sdk/core/azure-core/tests/test_serialization.py index 2f7a1f9c8da3..cc94b1092142 100644 --- a/sdk/core/azure-core/tests/test_serialization.py +++ b/sdk/core/azure-core/tests/test_serialization.py @@ -695,7 +695,7 @@ class MyModel(HybridModel): def test_dictionary_set_datetime(): """Test that dictionary with datetime values properly serializes/deserializes.""" - from datetime import datetime, timezone + from datetime import timezone class MyModel(HybridModel): my_dict: Dict[str, datetime] = rest_field(visibility=["read", "create", "update", "delete", "query"]) diff --git a/sdk/core/azure-core/tests/test_streaming.py b/sdk/core/azure-core/tests/test_streaming.py index c90a227b9d2c..4abffa1cdbb7 100644 --- a/sdk/core/azure-core/tests/test_streaming.py +++ b/sdk/core/azure-core/tests/test_streaming.py @@ -29,7 +29,6 @@ from azure.core.pipeline.transport import RequestsTransport from azure.core import PipelineClient from azure.core.exceptions import DecodeError -from azure.core.pipeline.transport import RequestsTransport @pytest.mark.parametrize("http_request", HTTP_REQUESTS) From 3736f44fc44dc84a28fc71878cbce4145ee6be4c Mon Sep 17 00:00:00 2001 From: Kashif Khan Date: Fri, 31 Jul 2026 14:52:41 -0500 Subject: [PATCH 5/9] suppress abstract import warning --- sdk/core/azure-core/samples/example_shared_transport.py | 2 +- .../azure-core/samples/example_shared_transport_async.py | 2 +- .../azure-core/samples/example_truststore_ssl_context.py | 5 ++++- sdk/core/azure-core/samples/test_example_async.py | 2 +- sdk/core/azure-core/samples/test_example_policies.py | 2 +- sdk/core/azure-core/samples/test_example_sync.py | 2 +- 6 files changed, 9 insertions(+), 6 deletions(-) diff --git a/sdk/core/azure-core/samples/example_shared_transport.py b/sdk/core/azure-core/samples/example_shared_transport.py index cd7ae90b2570..3f33620c5d66 100644 --- a/sdk/core/azure-core/samples/example_shared_transport.py +++ b/sdk/core/azure-core/samples/example_shared_transport.py @@ -20,7 +20,7 @@ """ import os -from azure.core.pipeline.transport import RequestsTransport +from azure.core.pipeline.transport import RequestsTransport # pylint: disable=non-abstract-transport-import from azure.storage.blob import BlobServiceClient connection_string = os.environ["AZURE_STORAGE_CONNECTION_STRING"] diff --git a/sdk/core/azure-core/samples/example_shared_transport_async.py b/sdk/core/azure-core/samples/example_shared_transport_async.py index 8f298c8069dd..4007b6cc01a6 100644 --- a/sdk/core/azure-core/samples/example_shared_transport_async.py +++ b/sdk/core/azure-core/samples/example_shared_transport_async.py @@ -21,7 +21,7 @@ import os import asyncio -from azure.core.pipeline.transport import AioHttpTransport +from azure.core.pipeline.transport import AioHttpTransport # pylint: disable=non-abstract-transport-import from azure.storage.blob.aio import BlobServiceClient connection_string = os.environ["AZURE_STORAGE_CONNECTION_STRING"] diff --git a/sdk/core/azure-core/samples/example_truststore_ssl_context.py b/sdk/core/azure-core/samples/example_truststore_ssl_context.py index 01d5cda1e2d4..1c2b7fbd5284 100644 --- a/sdk/core/azure-core/samples/example_truststore_ssl_context.py +++ b/sdk/core/azure-core/samples/example_truststore_ssl_context.py @@ -33,7 +33,10 @@ from azure.identity.aio import DefaultAzureCredential as AsyncDefaultAzureCredential from azure.storage.blob import BlobServiceClient from azure.storage.blob.aio import BlobServiceClient as AsyncBlobServiceClient -from azure.core.pipeline.transport import RequestsTransport, AioHttpTransport +from azure.core.pipeline.transport import ( # pylint: disable=non-abstract-transport-import + RequestsTransport, + AioHttpTransport, +) # ============================================================================= diff --git a/sdk/core/azure-core/samples/test_example_async.py b/sdk/core/azure-core/samples/test_example_async.py index e2b78c709b15..2bb3fd16597d 100644 --- a/sdk/core/azure-core/samples/test_example_async.py +++ b/sdk/core/azure-core/samples/test_example_async.py @@ -23,7 +23,7 @@ # THE SOFTWARE. # # -------------------------------------------------------------------------- -# pylint: disable=reimported +# pylint: disable=reimported,non-abstract-transport-import from typing import Iterable, MutableSequence, Union import pytest diff --git a/sdk/core/azure-core/samples/test_example_policies.py b/sdk/core/azure-core/samples/test_example_policies.py index 9cb4739ebcb5..38c8080ab890 100644 --- a/sdk/core/azure-core/samples/test_example_policies.py +++ b/sdk/core/azure-core/samples/test_example_policies.py @@ -32,7 +32,7 @@ def callback(response): from azure.core.pipeline import Pipeline from azure.core.rest import HttpRequest - from azure.core.pipeline.transport import RequestsTransport + from azure.core.pipeline.transport import RequestsTransport # pylint: disable=non-abstract-transport-import from azure.core.pipeline.policies import CustomHookPolicy request = HttpRequest("GET", "https://bing.com") diff --git a/sdk/core/azure-core/samples/test_example_sync.py b/sdk/core/azure-core/samples/test_example_sync.py index f175eed80698..27cf502c510a 100644 --- a/sdk/core/azure-core/samples/test_example_sync.py +++ b/sdk/core/azure-core/samples/test_example_sync.py @@ -23,7 +23,7 @@ # THE SOFTWARE. # # -------------------------------------------------------------------------- -# pylint: disable=reimported +# pylint: disable=reimported,non-abstract-transport-import from typing import Iterable, MutableSequence, Union from azure.core.pipeline import Pipeline from azure.core import PipelineClient From 24fded6cd86e57a86c6e77f37773a48572b6c47a Mon Sep 17 00:00:00 2001 From: Kashif Khan Date: Fri, 31 Jul 2026 14:59:42 -0500 Subject: [PATCH 6/9] suppress networking import outside core errors --- sdk/core/azure-core/samples/example_shared_transport.py | 3 ++- .../azure-core/samples/example_shared_transport_async.py | 3 ++- .../azure-core/samples/example_truststore_ssl_context.py | 6 ++---- sdk/core/azure-core/samples/test_example_async.py | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/sdk/core/azure-core/samples/example_shared_transport.py b/sdk/core/azure-core/samples/example_shared_transport.py index 3f33620c5d66..783cbad72e03 100644 --- a/sdk/core/azure-core/samples/example_shared_transport.py +++ b/sdk/core/azure-core/samples/example_shared_transport.py @@ -19,8 +19,9 @@ 1) AZURE_STORAGE_CONNECTION_STRING - the endpoint of your Azure Metrics Advisor service """ +# pylint: disable=non-abstract-transport-import,networking-import-outside-azure-core-transport import os -from azure.core.pipeline.transport import RequestsTransport # pylint: disable=non-abstract-transport-import +from azure.core.pipeline.transport import RequestsTransport from azure.storage.blob import BlobServiceClient connection_string = os.environ["AZURE_STORAGE_CONNECTION_STRING"] diff --git a/sdk/core/azure-core/samples/example_shared_transport_async.py b/sdk/core/azure-core/samples/example_shared_transport_async.py index 4007b6cc01a6..fed64eef9606 100644 --- a/sdk/core/azure-core/samples/example_shared_transport_async.py +++ b/sdk/core/azure-core/samples/example_shared_transport_async.py @@ -19,9 +19,10 @@ 1) AZURE_STORAGE_CONNECTION_STRING - the endpoint of your Azure Metrics Advisor service """ +# pylint: disable=non-abstract-transport-import,networking-import-outside-azure-core-transport import os import asyncio -from azure.core.pipeline.transport import AioHttpTransport # pylint: disable=non-abstract-transport-import +from azure.core.pipeline.transport import AioHttpTransport from azure.storage.blob.aio import BlobServiceClient connection_string = os.environ["AZURE_STORAGE_CONNECTION_STRING"] diff --git a/sdk/core/azure-core/samples/example_truststore_ssl_context.py b/sdk/core/azure-core/samples/example_truststore_ssl_context.py index 1c2b7fbd5284..79365214ab1d 100644 --- a/sdk/core/azure-core/samples/example_truststore_ssl_context.py +++ b/sdk/core/azure-core/samples/example_truststore_ssl_context.py @@ -22,6 +22,7 @@ python example_truststore_ssl_context.py """ +# pylint: disable=non-abstract-transport-import,networking-import-outside-azure-core-transport import ssl import asyncio import truststore @@ -33,10 +34,7 @@ from azure.identity.aio import DefaultAzureCredential as AsyncDefaultAzureCredential from azure.storage.blob import BlobServiceClient from azure.storage.blob.aio import BlobServiceClient as AsyncBlobServiceClient -from azure.core.pipeline.transport import ( # pylint: disable=non-abstract-transport-import - RequestsTransport, - AioHttpTransport, -) +from azure.core.pipeline.transport import RequestsTransport, AioHttpTransport # ============================================================================= diff --git a/sdk/core/azure-core/samples/test_example_async.py b/sdk/core/azure-core/samples/test_example_async.py index 2bb3fd16597d..b630d81ee0be 100644 --- a/sdk/core/azure-core/samples/test_example_async.py +++ b/sdk/core/azure-core/samples/test_example_async.py @@ -23,7 +23,7 @@ # THE SOFTWARE. # # -------------------------------------------------------------------------- -# pylint: disable=reimported,non-abstract-transport-import +# pylint: disable=reimported,non-abstract-transport-import,networking-import-outside-azure-core-transport from typing import Iterable, MutableSequence, Union import pytest From 6e347cced9577f28b5d455c1b16fe4b0535ae161 Mon Sep 17 00:00:00 2001 From: Kashif Khan Date: Fri, 31 Jul 2026 15:08:49 -0500 Subject: [PATCH 7/9] fix minor import --- sdk/core/azure-core/tests/perf_tests/_test_base.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/core/azure-core/tests/perf_tests/_test_base.py b/sdk/core/azure-core/tests/perf_tests/_test_base.py index b76e3f067de7..bf1df70535b9 100644 --- a/sdk/core/azure-core/tests/perf_tests/_test_base.py +++ b/sdk/core/azure-core/tests/perf_tests/_test_base.py @@ -31,7 +31,7 @@ BearerTokenCredentialPolicy, AsyncBearerTokenCredentialPolicy, ) -import azure.core.pipeline.policies as policies +from azure.core.pipeline import policies from azure.core.credentials import AzureNamedKeyCredential from azure.core.exceptions import ( ClientAuthenticationError, From f28fbcbd8b1ab0249ee3c10a24287fb93cf1e5e8 Mon Sep 17 00:00:00 2001 From: Kashif Khan Date: Fri, 31 Jul 2026 16:06:00 -0500 Subject: [PATCH 8/9] revert suppressions --- sdk/core/azure-core/samples/test_example_async.py | 2 +- sdk/core/azure-core/samples/test_example_sansio.py | 1 - sdk/core/azure-core/samples/test_example_sync.py | 2 +- .../azure-core/tests/async_tests/test_basic_transport_async.py | 3 --- 4 files changed, 2 insertions(+), 6 deletions(-) diff --git a/sdk/core/azure-core/samples/test_example_async.py b/sdk/core/azure-core/samples/test_example_async.py index b630d81ee0be..423e9f2f3fa6 100644 --- a/sdk/core/azure-core/samples/test_example_async.py +++ b/sdk/core/azure-core/samples/test_example_async.py @@ -23,7 +23,7 @@ # THE SOFTWARE. # # -------------------------------------------------------------------------- -# pylint: disable=reimported,non-abstract-transport-import,networking-import-outside-azure-core-transport +# pylint: disable=non-abstract-transport-import,networking-import-outside-azure-core-transport from typing import Iterable, MutableSequence, Union import pytest diff --git a/sdk/core/azure-core/samples/test_example_sansio.py b/sdk/core/azure-core/samples/test_example_sansio.py index 7fb687b3c317..f7f5aed5ddc0 100644 --- a/sdk/core/azure-core/samples/test_example_sansio.py +++ b/sdk/core/azure-core/samples/test_example_sansio.py @@ -23,7 +23,6 @@ # THE SOFTWARE. # # -------------------------------------------------------------------------- -# pylint: disable=reimported from azure.core.pipeline import PipelineRequest from azure.core.rest import HttpRequest, HttpResponse diff --git a/sdk/core/azure-core/samples/test_example_sync.py b/sdk/core/azure-core/samples/test_example_sync.py index 27cf502c510a..c9496b249369 100644 --- a/sdk/core/azure-core/samples/test_example_sync.py +++ b/sdk/core/azure-core/samples/test_example_sync.py @@ -23,7 +23,7 @@ # THE SOFTWARE. # # -------------------------------------------------------------------------- -# pylint: disable=reimported,non-abstract-transport-import +# pylint: disable=non-abstract-transport-import from typing import Iterable, MutableSequence, Union from azure.core.pipeline import Pipeline from azure.core import PipelineClient diff --git a/sdk/core/azure-core/tests/async_tests/test_basic_transport_async.py b/sdk/core/azure-core/tests/async_tests/test_basic_transport_async.py index 1e239a324a4f..2498b8aace03 100644 --- a/sdk/core/azure-core/tests/async_tests/test_basic_transport_async.py +++ b/sdk/core/azure-core/tests/async_tests/test_basic_transport_async.py @@ -970,9 +970,6 @@ async def test_recursive_multipart_receive(http_request, mock_response): @pytest.mark.skipif(sys.version_info < (3, 10), reason="Loop parameter is deprecated since Python 3.10") def test_aiohttp_loop(): - import asyncio - from azure.core.pipeline.transport import AioHttpTransport - loop = asyncio.new_event_loop() try: with pytest.raises(ValueError): From eb09d4c4a13fd33449511eb95090437eff5b0c2e Mon Sep 17 00:00:00 2001 From: Kashif Khan Date: Fri, 31 Jul 2026 16:38:28 -0500 Subject: [PATCH 9/9] update cspell --- sdk/core/cspell.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/sdk/core/cspell.yaml b/sdk/core/cspell.yaml index a45305d3471a..1f9555384412 100644 --- a/sdk/core/cspell.yaml +++ b/sdk/core/cspell.yaml @@ -12,6 +12,7 @@ words: - ctype - cvar - datav + - français - getpgid - hdrs - inirudebwoy