Split capped PR velocity days by repository#20
Open
mahangu wants to merge 6 commits into
Open
Conversation
Author
|
Updated the PR description with the public rationale: day slicing can still exceed GitHub GraphQL Search's 1,000-result node cap, so the repo split keeps leaf queries smaller while reconciliation keeps incomplete splits fail-fast. Also trimmed duplicate created-date split test setup. |
- Remove unused org parameter threaded through _iter_processable_queries and _iter_repo_queries_for_capped_day; org is derived from the query regex - Fix misleading error when a capped day query has no org:/repo: qualifier - Document why CREATED_SEARCH_START_DATE is 2008-01-01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pr_velocityqueries that still exceed GitHub GraphQL Search's 1,000-result node cap after day slicingRationale
Day slicing alone is not always selective enough for high-volume repositories or organizations. A direct day-to-created-date fallback is smaller, but it can still hit the cap when many PRs share the same created and closed day. The repository step keeps leaf queries smaller while the reconciliation checks preserve fail-fast behavior.
Testing
poetry run pytest tap_github_search/tests