Repository navigation
Conversation
…rror-needs-network) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DZvaN9tm5taf5avUvVtmyq
Member
Author
|
Withdrawn: the catalog never runs applications with network access, not even for a diagnosis. An application that wants to be in the catalog must work without network, or at least show a message. The hint for Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
error-app-exitsis the largest failure class (1,931 open PRs), and its hint can only say "the error below usually shows why". A common cause is that the test runs without network on purpose (firejail --net=none) and the application wants a login or update check before it shows anything.worker.sh: when the application showed no window (and is not a terminal application, and the tray attempt did not help either), it is run once more with network access, for up to 30 seconds, only to diagnose. If a window appears, the log getsNOTE: With network access the application shows a window: it needs the network to start, anddiagnose.shturns that into the labelerror-needs-networkwith a hint: an AppImage must start without network; show the window first, log in or check for updates afterwards, handle a failed connection. The test fails either way, as before; nothing is relaxed. The second instance is left to the cleanup trap, which captures the failure screen first (so the PR comment then shows the window that needs the network) and kills it.Cost: up to 30 seconds more for a failing test. The second run writes its output to a file, so no background process holds the log pipe (the rule in AGENTS.md).
Checked:
bash -n,shellcheck,diagnose.shon a sample log (labelserror-app-exits error-needs-network; the excerpt starts at the NOTE, right above the error). The run itself cannot be tried from my sandbox (no firejail); a throwaway PR with a network-needing app would show it end to end after merging, if you want one.AGENTS.mddescribes it.🤖 Generated with Claude Code
https://claude.ai/code/session_01DZvaN9tm5taf5avUvVtmyq
Generated by Claude Code