Skip to content

[PWGLF] Feat/antin cex hist update#16313

Open
FabiolaLP wants to merge 7 commits into
AliceO2Group:masterfrom
FabiolaLP:feat/antin-cex-hist-update
Open

[PWGLF] Feat/antin cex hist update#16313
FabiolaLP wants to merge 7 commits into
AliceO2Group:masterfrom
FabiolaLP:feat/antin-cex-hist-update

Conversation

@FabiolaLP
Copy link
Copy Markdown
Contributor

This PR updates the antineutron CEX analysis task and corresponding data model.

Main changes:

Removed obsolete histograms.
Added new histograms for updated analysis studies.
Updated the content of LFAntinCexTables.
Minor cleanup and consistency updates in the task output.

The task was rebuilt and tested successfully in a fresh O2Physics installation.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

O2 linter results: ❌ 3 errors, ⚠️ 20 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Feat/antin cex hist update [PWGLF] Feat/antin cex hist update May 19, 2026
@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 767bf57 at 2026-05-20 01:26:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/nucleiAntineutronCex.cxx:270:16: error: variable 'motherPx' set but not used [-Werror=unused-but-set-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/nucleiAntineutronCex.cxx:271:16: error: variable 'motherPy' set but not used [-Werror=unused-but-set-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/nucleiAntineutronCex.cxx:277:13: error: variable 'motherId' set but not used [-Werror=unused-but-set-variable]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 767bf57 at 2026-05-20 01:32:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/nucleiAntineutronCex.cxx:270:16: error: variable 'motherPx' set but not used [-Werror=unused-but-set-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/nucleiAntineutronCex.cxx:271:16: error: variable 'motherPy' set but not used [-Werror=unused-but-set-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/nucleiAntineutronCex.cxx:277:13: error: variable 'motherId' set but not used [-Werror=unused-but-set-variable]
ninja: build stopped: subcommand failed.

Full log here.

Comment thread PWGLF/TableProducer/Nuspex/nucleiAntineutronCex.cxx Outdated
@vkucera vkucera marked this pull request as draft May 22, 2026 22:31
@FabiolaLP FabiolaLP marked this pull request as ready for review May 28, 2026 17:27
@FabiolaLP FabiolaLP requested a review from vkucera May 30, 2026 06:22
Comment thread PWGLF/DataModel/LFAntinCexTables.h Outdated
@vkucera vkucera marked this pull request as draft May 30, 2026 18:08
@FabiolaLP FabiolaLP marked this pull request as ready for review May 30, 2026 21:31
@FabiolaLP FabiolaLP requested a review from vkucera June 1, 2026 20:08
@maciacco maciacco enabled auto-merge (squash) June 3, 2026 06:33
@maciacco
Copy link
Copy Markdown
Collaborator

maciacco commented Jun 3, 2026

hi @vkucera could you please approve from your side?


#include <CommonConstants/MathConstants.h>
#include <DCAFitter/DCAFitterN.h>
#include <DetectorsBase/Propagator.h>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this used?

// Detector signal
bool antipLayers = false;
// Reconstructed data
bool antipLayers_condition = false;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to follow the naming conventions when introducing new names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants