Skip to content

[ALICE3] TF3: Move hard-coded digitizer parameters to dpldigitizerparams#15623

Open
maciacco wants to merge 9 commits into
AliceO2Group:devfrom
maciacco:patch-2
Open

[ALICE3] TF3: Move hard-coded digitizer parameters to dpldigitizerparams#15623
maciacco wants to merge 9 commits into
AliceO2Group:devfrom
maciacco:patch-2

Conversation

@maciacco

@maciacco maciacco commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@maciacco
maciacco marked this pull request as ready for review July 22, 2026 13:05
@maciacco maciacco changed the title Move hard-coded digitizer parameters to dpldigitizerparams [ALICE3] TF3: Move hard-coded digitizer parameters to dpldigitizerparams Jul 22, 2026
njacazio
njacazio previously approved these changes Jul 22, 2026
View reviewed changes
@njacazio
njacazio enabled auto-merge (squash) July 22, 2026 13:52
auto-merge was automatically disabled July 22, 2026 14:02

Head branch was pushed to by a user without write access

@maciacco
maciacco marked this pull request as draft July 22, 2026 14:23
@maciacco
maciacco marked this pull request as ready for review July 22, 2026 16:36
@alibuild

alibuild commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 6308b32 at 2026-07-22 20:31:

## sw/BUILD/O2-latest/log
input_line_9:455:40: error: use of undeclared identifier 'mChargeThreshold'
input_line_9:456:39: error: use of undeclared identifier 'mTimeResolution'
input_line_9:457:35: error: use of undeclared identifier 'mEfficiency'
input_line_9:458:39: error: use of undeclared identifier 'mEnergyToCharge'
input_line_9:461:45: error: use of undeclared identifier 'mChargeThreshold'
input_line_9:462:44: error: use of undeclared identifier 'mTimeResolution'
input_line_9:463:40: error: use of undeclared identifier 'mEfficiency'
Error: /sw/slc9_x86-64/ROOT/v6-36-10-alice2-2/bin/rootcling: compilation failure (/sw/BUILD/dc1cc7672652df81517bd898edec5b3b439c955c/O2/Detectors/Upgrades/ALICE3/IOTOF/simulation/G__O2IOTOFSimulation7dc850176d_dictUmbrella.h)
ninja: build stopped: subcommand failed.

Full log here.

@njacazio
njacazio enabled auto-merge (squash) July 23, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@njacazio njacazio njacazio approved these changes
@mconcas mconcas Awaiting requested review from mconcas mconcas is a code owner
@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner
@sawenzel sawenzel Awaiting requested review from sawenzel sawenzel is a code owner
@shahor02 shahor02 Awaiting requested review from shahor02 shahor02 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maciacco @alibuild @njacazio