Skip to content

Commit 6b31c6e

Browse files
authored
Move inline function to header to avoid linking issue with gcc
Co-authored-by: Anton Alkin <anton.alkin@cern.ch>
1 parent dfa07ab commit 6b31c6e

2 files changed

Lines changed: 7 additions & 8 deletions

File tree

Framework/Core/include/Framework/ASoA.h

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,13 @@ void missingFilterDeclaration(int hash, int ai);
5858
void notBoundTable(const char* tableName);
5959
void* extractCCDBPayload(char* payload, size_t size, TClass const* cl, const char* what);
6060

61-
constexpr char asciiToLower(char c);
61+
// ASCII-only lowercase. Column labels are plain identifiers, so we deliberately
62+
// avoid the locale-aware std::tolower: it goes through the C locale facet on
63+
// every character and dominated getIndexFromLabel in profiles.
64+
constexpr char asciiToLower(char c)
65+
{
66+
return (c >= 'A' && c <= 'Z') ? static_cast<char>(c + 32) : c;
67+
}
6268

6369
template <typename... C>
6470
auto createFieldsFromColumns(framework::pack<C...>)

Framework/Core/src/ASoA.cxx

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -207,13 +207,6 @@ o2::soa::ArrowTableRef ArrowHelpers::concatTables(std::vector<o2::soa::ArrowTabl
207207
return {arrow::Table::Make(std::make_shared<arrow::Schema>(resultFields), columns)};
208208
}
209209

210-
// ASCII-only lowercase. Column labels are plain identifiers, so we deliberately
211-
// avoid the locale-aware std::tolower: it goes through the C locale facet on
212-
// every character and dominated getIndexFromLabel in profiles.
213-
constexpr char asciiToLower(char c)
214-
{
215-
return (c >= 'A' && c <= 'Z') ? static_cast<char>(c + 32) : c;
216-
}
217210

218211
arrow::ChunkedArray* getIndexFromLabel(arrow::Table* table, std::string_view label)
219212
{

0 commit comments

Comments
 (0)