Make cart, checkout, navigation tests reliable in CI

CI against live SauceDemo surfaced deterministic failures in cart/menu flows
(login, inventory and sorting already passed). Fixes:

- Confirm add/remove by waiting for the product button to toggle Add<->Remove,
  removing cart-badge read races.
- Open the cart via a JS click on the anchor: once the badge is shown it
  overlaps the link centre, so a native click hit the badge span and
  navigation never fired.
- JS-click burger-menu items (logout, reset, close) to avoid missing the
  element while the menu is mid-animation; wait on aria-hidden state.
- Make BasePage.click scroll into view with a JS-click fallback.
- Confirm cart removal by waiting for the row to disappear.
- Run the regression suite sequentially for CI stability (framework remains
  parallel-safe via the ThreadLocal driver).

Author: AjayAstro

src/main/java/com/saucedemo/pages/BasePage.java

@@ -2,6 +2,8 @@
 
 import com.saucedemo.config.ConfigManager;
 import org.openqa.selenium.By;
+import org.openqa.selenium.ElementClickInterceptedException;
+import org.openqa.selenium.JavascriptExecutor;
 import org.openqa.selenium.WebDriver;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.support.ui.ExpectedConditions;
@@ -41,8 +43,35 @@ protected WebElement waitForClickable(By locator) {
         return wait.until(ExpectedConditions.elementToBeClickable(locator));
     }
 
+    /**
+     * Clicks an element after scrolling it into view, falling back to a
+     * JavaScript click if the native click is intercepted (e.g. by a sticky
+     * header or an in-flight animation). This keeps interactions reliable in
+     * headless/CI runs without resorting to sleeps.
+     */
     protected void click(By locator) {
-        waitForClickable(locator).click();
+        WebElement element = waitForClickable(locator);
+        scrollIntoView(element);
+        try {
+            element.click();
+        } catch (ElementClickInterceptedException e) {
+            jsClick(element);
+        }
+    }
+
+    /** Dispatches a click via JavaScript; robust against animated/offset elements. */
+    protected void jsClick(By locator) {
+        jsClick(wait.until(ExpectedConditions.presenceOfElementLocated(locator)));
+    }
+
+    private void jsClick(WebElement element) {
+        scrollIntoView(element);
+        ((JavascriptExecutor) driver).executeScript("arguments[0].click();", element);
+    }
+
+    protected void scrollIntoView(WebElement element) {
+        ((JavascriptExecutor) driver)
+                .executeScript("arguments[0].scrollIntoView({block:'center'});", element);
     }
 
     protected void type(By locator, String text) {

src/main/java/com/saucedemo/pages/CartPage.java

@@ -4,6 +4,7 @@
 import org.openqa.selenium.By;
 import org.openqa.selenium.WebDriver;
 import org.openqa.selenium.WebElement;
+import org.openqa.selenium.support.ui.ExpectedConditions;
 
 import java.util.List;
 
@@ -45,11 +46,11 @@ public boolean containsItem(String productName) {
 
     @Step("Remove product from cart: {productName}")
     public CartPage removeItem(String productName) {
-        By removeButton = By.xpath(
-                "//div[contains(@class,'cart_item')]"
-                        + "[.//*[@data-test='inventory-item-name' and normalize-space()=\"" + productName + "\"]]"
-                        + "//button");
-        click(removeButton);
+        String rowXpath = "//div[contains(@class,'cart_item')]"
+                + "[.//*[@data-test='inventory-item-name' and normalize-space()=\"" + productName + "\"]]";
+        click(By.xpath(rowXpath + "//button"));
+        // Confirm removal: the item's row is gone from the cart.
+        wait.until(ExpectedConditions.invisibilityOfElementLocated(By.xpath(rowXpath)));
         return this;
     }
 

src/main/java/com/saucedemo/pages/HeaderComponent.java

@@ -29,13 +29,16 @@ public HeaderComponent(WebDriver driver) {
     @Step("Open the navigation menu")
     public HeaderComponent openMenu() {
         click(BURGER_MENU_BUTTON);
-        waitForClickable(LOGOUT_LINK);
+        // Menu is open once the wrapper is no longer aria-hidden.
+        wait.until(ExpectedConditions.attributeToBe(MENU_WRAP, "aria-hidden", "false"));
+        wait.until(ExpectedConditions.presenceOfElementLocated(LOGOUT_LINK));
         return this;
     }
 
     @Step("Close the navigation menu")
     public HeaderComponent closeMenu() {
-        click(CLOSE_MENU_BUTTON);
+        // JS-click avoids missing the cross button while the menu is animating.
+        jsClick(CLOSE_MENU_BUTTON);
         // The menu wrapper is hidden (aria-hidden=true) once the slide-out finishes.
         wait.until(ExpectedConditions.attributeToBe(MENU_WRAP, "aria-hidden", "true"));
         return this;
@@ -50,21 +53,28 @@ public boolean isMenuOpen() {
     @Step("Log out")
     public LoginPage logout() {
         openMenu();
-        click(LOGOUT_LINK);
+        // JS-click the link to avoid the moving-target problem during the slide.
+        jsClick(LOGOUT_LINK);
+        // Logout is complete once the login form is back.
+        wait.until(ExpectedConditions.presenceOfElementLocated(By.id("login-button")));
         return new LoginPage(driver);
     }
 
     @Step("Reset application state")
     public HeaderComponent resetAppState() {
         openMenu();
-        click(RESET_LINK);
+        jsClick(RESET_LINK);
         closeMenu();
         return this;
     }
 
     @Step("Open the cart")
     public CartPage openCart() {
-        click(CART_LINK);
+        // JS-click the anchor itself: once a badge is shown it overlaps the link
+        // centre, and a native click can land on the badge span instead of the
+        // anchor, so navigation never fires.
+        jsClick(CART_LINK);
+        wait.until(ExpectedConditions.urlContains("cart.html"));
         return new CartPage(driver);
     }
 

src/main/java/com/saucedemo/pages/InventoryPage.java

@@ -79,13 +79,17 @@ public InventoryPage sortBy(SortOption option) {
 
     @Step("Add product to cart: {productName}")
     public InventoryPage addProductToCart(String productName) {
-        actionButtonFor(productName).click();
+        clickActionButton(productName);
+        // Confirm the action registered: the button toggles to "Remove".
+        waitForButtonState(productName, "remove");
         return this;
     }
 
     @Step("Remove product from cart: {productName}")
     public InventoryPage removeProductFromCart(String productName) {
-        actionButtonFor(productName).click();
+        clickActionButton(productName);
+        // Confirm the action registered: the button toggles back to "Add to cart".
+        waitForButtonState(productName, "add-to-cart");
         return this;
     }
 
@@ -94,16 +98,35 @@ public HeaderComponent header() {
     }
 
     /**
-     * Returns the Add/Remove button that belongs to the card for {@code productName}.
-     * Locating relative to the product card keeps the action robust regardless of
-     * the current sort order or the button's add/remove state.
+     * Clicks the Add/Remove button on the card for {@code productName}. Locating
+     * relative to the product card keeps the action robust regardless of the
+     * current sort order or the button's add/remove state.
      */
-    private WebElement actionButtonFor(String productName) {
-        By itemButton = By.xpath(
+    private void clickActionButton(String productName) {
+        click(actionButtonLocator(productName));
+    }
+
+    private By actionButtonLocator(String productName) {
+        return By.xpath(
                 "//div[contains(@class,'inventory_item')]"
                         + "[.//*[@data-test='inventory-item-name' and normalize-space()=\"" + productName + "\"]]"
                         + "//button");
-        return waitForClickable(itemButton);
+    }
+
+    /**
+     * Waits until the card's button reflects the expected state, identified by
+     * the {@code data-test} prefix ("add-to-cart" or "remove"). This is the
+     * reliable signal that the click was processed by the app.
+     */
+    private void waitForButtonState(String productName, String dataTestPrefix) {
+        wait.until(d -> {
+            var buttons = d.findElements(actionButtonLocator(productName));
+            if (buttons.isEmpty()) {
+                return false;
+            }
+            String dataTest = buttons.get(0).getDomAttribute("data-test");
+            return dataTest != null && dataTest.startsWith(dataTestPrefix);
+        });
     }
 
     /** Convenience helper used by sorting tests to verify ordering. */

testng.xml

@@ -2,7 +2,9 @@
 <!DOCTYPE suite SYSTEM "https://testng.org/testng-1.0.dtd">
 
 <!-- Full regression suite: all UI tests plus the Cucumber BDD layer. -->
-<suite name="SauceDemo Regression" verbose="1" parallel="classes" thread-count="3">
+<!-- Runs sequentially for stability in CI. The framework is parallel-safe -->
+<!-- (ThreadLocal driver); set parallel="classes" thread-count="N" to scale. -->
+<suite name="SauceDemo Regression" verbose="1">
 
     <listeners>
         <listener class-name="com.saucedemo.listeners.TestListener"/>